Re: [PATCH] cpu_conf: unbreak XPath in virCPUDefParseXML()

2022-02-09 Thread Jiri Denemark
On Wed, Feb 09, 2022 at 14:28:29 +0100, Michal Prívozník wrote: > On 2/9/22 10:39, Daniel P. Berrangé wrote: > > On Tue, Feb 08, 2022 at 12:22:36PM +0100, Michal Privoznik wrote: > >> In one of my previous commits, I've changed an XPath in > >> virCPUDefParseXML() from "boolean(./counter...)" to >

Re: [PATCH] cpu_conf: unbreak XPath in virCPUDefParseXML()

2022-02-09 Thread Daniel P . Berrangé
On Wed, Feb 09, 2022 at 02:28:29PM +0100, Michal Prívozník wrote: > On 2/9/22 10:39, Daniel P. Berrangé wrote: > > On Tue, Feb 08, 2022 at 12:22:36PM +0100, Michal Privoznik wrote: > >> In one of my previous commits, I've changed an XPath in > >> virCPUDefParseXML() from "boolean(./counter...)" to

Re: [PATCH] cpu_conf: unbreak XPath in virCPUDefParseXML()

2022-02-09 Thread Michal Prívozník
On 2/9/22 10:39, Daniel P. Berrangé wrote: > On Tue, Feb 08, 2022 at 12:22:36PM +0100, Michal Privoznik wrote: >> In one of my previous commits, I've changed an XPath in >> virCPUDefParseXML() from "boolean(./counter...)" to >> "./counter...)". Notice the dangling closing bracket? Well, I >> didn't

Re: [PATCH] cpu_conf: unbreak XPath in virCPUDefParseXML()

2022-02-09 Thread Daniel P . Berrangé
On Tue, Feb 08, 2022 at 12:22:36PM +0100, Michal Privoznik wrote: > In one of my previous commits, I've changed an XPath in > virCPUDefParseXML() from "boolean(./counter...)" to > "./counter...)". Notice the dangling closing bracket? Well, I > didn't back then. Suggests we have missing test XML da

Re: [PATCH] cpu_conf: unbreak XPath in virCPUDefParseXML()

2022-02-08 Thread Ján Tomko
On a Tuesday in 2022, Michal Privoznik wrote: In one of my previous commits, I've changed an XPath in virCPUDefParseXML() from "boolean(./counter...)" to "./counter...)". Notice the dangling closing bracket? Well, I didn't back then. Fixes: 0fe2d8dd335054fae38b46bbbac58a4662e1a1d0 Signed-off-by:

[PATCH] cpu_conf: unbreak XPath in virCPUDefParseXML()

2022-02-08 Thread Michal Privoznik
In one of my previous commits, I've changed an XPath in virCPUDefParseXML() from "boolean(./counter...)" to "./counter...)". Notice the dangling closing bracket? Well, I didn't back then. Fixes: 0fe2d8dd335054fae38b46bbbac58a4662e1a1d0 Signed-off-by: Michal Privoznik --- src/conf/cpu_conf.c | 2