Re: [PATCH] nss: Finish renaming of HAVE_BSD_NSS macro

2020-09-01 Thread Michal Privoznik
On 9/1/20 11:42 AM, Daniel P. Berrangé wrote: On Tue, Sep 01, 2020 at 11:26:58AM +0200, Michal Privoznik wrote: When switching to meson, some of HAVE_* macros were renamed to WITH_ because they did not reflect whether the build platform has or doesn't have something, but whether we are building

Re: [PATCH] nss: Finish renaming of HAVE_BSD_NSS macro

2020-09-01 Thread Daniel P . Berrangé
On Tue, Sep 01, 2020 at 11:26:58AM +0200, Michal Privoznik wrote: > When switching to meson, some of HAVE_* macros were renamed to > WITH_ because they did not reflect whether the build platform has > or doesn't have something, but whether we are building with some > functionality turned on or off.

Re: [PATCH] nss: Finish renaming of HAVE_BSD_NSS macro

2020-09-01 Thread Jiri Denemark
On Tue, Sep 01, 2020 at 11:26:58 +0200, Michal Privoznik wrote: > When switching to meson, some of HAVE_* macros were renamed to > WITH_ because they did not reflect whether the build platform has > or doesn't have something, but whether we are building with some > functionality turned on or off. T

Re: [PATCH] nss: Finish renaming of HAVE_BSD_NSS macro

2020-09-01 Thread Roman Bogorodskiy
Michal Privoznik wrote: > When switching to meson, some of HAVE_* macros were renamed to > WITH_ because they did not reflect whether the build platform has > or doesn't have something, but whether we are building with some > functionality turned on or off. This is the case with > HAVE_BSD_NSS m

[PATCH] nss: Finish renaming of HAVE_BSD_NSS macro

2020-09-01 Thread Michal Privoznik
When switching to meson, some of HAVE_* macros were renamed to WITH_ because they did not reflect whether the build platform has or doesn't have something, but whether we are building with some functionality turned on or off. This is the case with HAVE_BSD_NSS macro too. As a result, the NSS plugin