Re: [PATCH] qemu: blockjob: Transition into 'ready' state only from expected states

2021-04-21 Thread Michal Privoznik
On 4/20/21 1:44 PM, Peter Krempa wrote: In certain rare occasions qemu can transition a block job which was already 'ready' into 'standby' and then back. If this happens in the following order libvirt will get confused about the actual job state: 1) the block copy job is 'ready' (job->state == Q

Re: [PATCH] qemu: blockjob: Transition into 'ready' state only from expected states

2021-04-21 Thread Peter Krempa
On Tue, Apr 20, 2021 at 15:07:03 +0300, Nir Soffer wrote: > On Tue, Apr 20, 2021 at 2:45 PM Peter Krempa wrote: > > > > In certain rare occasions qemu can transition a block job which was > > already 'ready' into 'standby' and then back. If this happens in the > > following order libvirt will get

Re: [PATCH] qemu: blockjob: Transition into 'ready' state only from expected states

2021-04-20 Thread Nir Soffer
On Tue, Apr 20, 2021 at 2:45 PM Peter Krempa wrote: > > In certain rare occasions qemu can transition a block job which was > already 'ready' into 'standby' and then back. If this happens in the > following order libvirt will get confused about the actual job state: > > 1) the block copy job is 'r

[PATCH] qemu: blockjob: Transition into 'ready' state only from expected states

2021-04-20 Thread Peter Krempa
In certain rare occasions qemu can transition a block job which was already 'ready' into 'standby' and then back. If this happens in the following order libvirt will get confused about the actual job state: 1) the block copy job is 'ready' (job->state == QEMU_BLOCKJOB_STATE_READY) 2) user calls q