Updated the patch with the suggested changes. The last commit for the new
patch is
https://www.redhat.com/archives/libvir-list/2020-November/msg01324.html.
On Fri, Nov 20, 2020 at 2:55 PM Laine Stump wrote:
> On 11/20/20 11:43 AM, Barrett J Schonefeld wrote:
> > I appreciate the feedback on this
On 11/20/20 11:43 AM, Barrett J Schonefeld wrote:
I appreciate the feedback on this patch!
I will work on splitting this into multiple patches. I believe this will
involve redoing much of the work because I will need to split this patch
(a single commit) into many commits.
One suggestion on
I appreciate the feedback on this patch!
I will work on splitting this into multiple patches. I believe this will
involve redoing much of the work because I will need to split this patch (a
single commit) into many commits. Hence, I'd like to get some confirmation
on how I should approach the patc
On 11/19/20 6:46 AM, Tim Wiederhake wrote:
On Wed, 2020-11-18 at 16:47 -0600, Ryan Gahagan wrote:
From: Barrett Schonefeld
additional conversions to the GLib API in src/util per issue #11.
[...]
return ret;
}
I believe you can remove "cleanup" and "ret" as well. More instances
On 11/18/20 9:40 PM, Barrett J Schonefeld wrote:
I spent a significant chunk of time trying to get `git send-email` working
but struggled to get the tool to work on my computer.
Is there an error message you're seeing? Is your SMTP server blocking
connection? Some use gmail to work around too
On Wed, 2020-11-18 at 16:47 -0600, Ryan Gahagan wrote:
> From: Barrett Schonefeld
>
> additional conversions to the GLib API in src/util per issue #11.
>
> Related issue: https://gitlab.com/libvirt/libvirt/-/issues/11
>
> Signed-off-by: Barrett Schonefeld
> ---
> src/util/vircgroupv1.c
From: Barrett Schonefeld
additional conversions to the GLib API in src/util per issue #11.
Related issue: https://gitlab.com/libvirt/libvirt/-/issues/11
Signed-off-by: Barrett Schonefeld
---
src/util/vircgroupv1.c | 3 +-
src/util/virdnsmasq.c| 43 -
.
On Wed, Nov 18, 2020 at 11:46 AM Michal Privoznik
wrote:
> On 11/17/20 9:45 PM, Barrett J Schonefeld wrote:
> >>From 82f992c7ff4ef59682f42c863fca242dd84208f9 Mon Sep 17 00:00:00 2001
> > From: Barrett Schonefeld
> > Date: Mon, 9 Nov 2020 16:07:25 -0600
> > Subje
On 11/17/20 9:45 PM, Barrett J Schonefeld wrote:
From 82f992c7ff4ef59682f42c863fca242dd84208f9 Mon Sep 17 00:00:00 2001
From: Barrett Schonefeld
Date: Mon, 9 Nov 2020 16:07:25 -0600
Subject: [PATCH] util: convert char pointers to use g_autofree
additional conversions to the GLib API in src
>From 82f992c7ff4ef59682f42c863fca242dd84208f9 Mon Sep 17 00:00:00 2001
From: Barrett Schonefeld
Date: Mon, 9 Nov 2020 16:07:25 -0600
Subject: [PATCH] util: convert char pointers to use g_autofree
additional conversions to the GLib API in src/util per issue #11.
Related issue: ht
On Mon, Nov 09, 2020 at 04:34:22PM -0600, Ryan Gahagan wrote:
> From: Barrett Schonefeld
>
> additional conversions to the GLib API in src/util per issue #11.
>
> files updated are:
> - src/util/vircgroupv1.c
> - src/util/virhostcpu.c
> - src/util/virlockspace.c
> - src/util/virmacmap.c
> - src/
On Tue, Nov 10, 2020 at 6:36 AM Ryan Gahagan wrote:
> From: Barrett Schonefeld
>
> additional conversions to the GLib API in src/util per issue #11.
>
> files updated are:
> - src/util/vircgroupv1.c
> - src/util/virhostcpu.c
> - src/util/virlockspace.c
> - src/util/virmacmap.c
> - src/util/virre
From: Barrett Schonefeld
additional conversions to the GLib API in src/util per issue #11.
files updated are:
- src/util/vircgroupv1.c
- src/util/virhostcpu.c
- src/util/virlockspace.c
- src/util/virmacmap.c
- src/util/virresctrl.c
- src/util/virsysinfo.c
Related issue: https://gitlab.com/libvi
13 matches
Mail list logo
