Re: [PATCH] virStorageSourceParseNBDColonString: Rewrite to match what qemu does

2020-04-24 Thread Peter Krempa
On Fri, Apr 24, 2020 at 10:02:49 -0500, Eric Blake wrote: > On 4/24/20 7:04 AM, Peter Krempa wrote: > > Our implementation wasn't quite able to parse everything that qemu does. > > This patch rewrites the parser to a code that semantically resembles the > > combination of 'nbd_parse_filename' and '

Re: [PATCH] virStorageSourceParseNBDColonString: Rewrite to match what qemu does

2020-04-24 Thread Eric Blake
On 4/24/20 7:04 AM, Peter Krempa wrote: Our implementation wasn't quite able to parse everything that qemu does. This patch rewrites the parser to a code that semantically resembles the combination of 'nbd_parse_filename' and 'inet_parse' methods in qemu to be able to parse the strings in an equi

[PATCH] virStorageSourceParseNBDColonString: Rewrite to match what qemu does

2020-04-24 Thread Peter Krempa
Our implementation wasn't quite able to parse everything that qemu does. This patch rewrites the parser to a code that semantically resembles the combination of 'nbd_parse_filename' and 'inet_parse' methods in qemu to be able to parse the strings in an equivalent manner. The only thing that libvir