Re: [PATCH 06/11] hyperv: attach virtual disks when defining domains

2021-01-11 Thread Daniel P . Berrangé
On Fri, Jan 08, 2021 at 05:55:55PM -0500, Matt Coleman wrote: > > On Nov 26, 2020, at 9:48 AM, Daniel P. Berrangé wrote: > > > > On Tue, Nov 24, 2020 at 02:48:35PM -0500, Matt Coleman wrote: > >> +g_autofree char *addressString = g_strdup_printf("%u", > >> disk->info.addr.drive.unit); > > >

Re: [PATCH 06/11] hyperv: attach virtual disks when defining domains

2021-01-08 Thread Matt Coleman
> On Nov 26, 2020, at 9:48 AM, Daniel P. Berrangé wrote: > > On Tue, Nov 24, 2020 at 02:48:35PM -0500, Matt Coleman wrote: >> +g_autofree char *addressString = g_strdup_printf("%u", >> disk->info.addr.drive.unit); > > Validate disk->info.type == DRIVE before accessing this field otherwise >

Re: [PATCH 06/11] hyperv: attach virtual disks when defining domains

2020-11-26 Thread Daniel P . Berrangé
On Tue, Nov 24, 2020 at 02:48:35PM -0500, Matt Coleman wrote: > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 244 +++- > src/hyperv/hyperv_wmi_classes.h | 1 + > 2 files changed, 242 insertions(+), 3 deletions

[PATCH 06/11] hyperv: attach virtual disks when defining domains

2020-11-24 Thread Matt Coleman
Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 244 +++- src/hyperv/hyperv_wmi_classes.h | 1 + 2 files changed, 242 insertions(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c