Re: [PATCH 09/12] virSecurityDeviceLabelDefParseXML: Use automatic memory clearing for temp strings

2021-11-23 Thread Ján Tomko
On a Monday in 2021, Peter Krempa wrote: On Mon, Nov 22, 2021 at 18:12:29 +0100, Peter Krempa wrote: Apart from code simplification the refactor of 'model' fixes an unlikely memory leak of the string if a duplicate model is found. While the coversion of 'label' variable may seem unnecessary it

Re: [PATCH 09/12] virSecurityDeviceLabelDefParseXML: Use automatic memory clearing for temp strings

2021-11-23 Thread Peter Krempa
On Mon, Nov 22, 2021 at 21:02:01 +0100, Tim Wiederhake wrote: > On Mon, 2021-11-22 at 18:12 +0100, Peter Krempa wrote: > > Apart from code simplification the refactor of 'model' fixes an > > unlikely > > memory leak of the string if a duplicate model is found. > > > > While the coversion of 'label

Re: [PATCH 09/12] virSecurityDeviceLabelDefParseXML: Use automatic memory clearing for temp strings

2021-11-22 Thread Tim Wiederhake
On Mon, 2021-11-22 at 18:12 +0100, Peter Krempa wrote: > Apart from code simplification the refactor of 'model' fixes an > unlikely > memory leak of the string if a duplicate model is found. > > While the coversion of 'label' variable may seem unnecessary it will > come in handy in the next patch.

Re: [PATCH 09/12] virSecurityDeviceLabelDefParseXML: Use automatic memory clearing for temp strings

2021-11-22 Thread Peter Krempa
On Mon, Nov 22, 2021 at 18:12:29 +0100, Peter Krempa wrote: > Apart from code simplification the refactor of 'model' fixes an unlikely > memory leak of the string if a duplicate model is found. > > While the coversion of 'label' variable may seem unnecessary it will > come in handy in the next pat

[PATCH 09/12] virSecurityDeviceLabelDefParseXML: Use automatic memory clearing for temp strings

2021-11-22 Thread Peter Krempa
Apart from code simplification the refactor of 'model' fixes an unlikely memory leak of the string if a duplicate model is found. While the coversion of 'label' variable may seem unnecessary it will come in handy in the next patch. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 14 +++