Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-08 Thread Jan-Marek Glogowski
Hi Am 08.09.20 um 08:07 schrieb Gerd Hoffmann: Also "info usb" just shows a single device. I just copied these lines from a normal libvirt SCSI setup with two cdroms. >>> >>> That is normal, it actually is only one usb device after all ;) >> >> I was referring to the posted usb-bot examp

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Gerd Hoffmann
Hi, > >> Also "info usb" just shows a single device. I just copied these lines > >> from a normal libvirt SCSI setup with two cdroms. > > > > That is normal, it actually is only one usb device after all ;) > > I was referring to the posted usb-bot example, where "your" docs > (/docs/usb-storag

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Jan-Marek Glogowski
Am 07.09.20 um 13:48 schrieb Daniel P. Berrangé: > On Mon, Sep 07, 2020 at 01:45:09PM +0200, Gerd Hoffmann wrote: ... > Switching back to -drive is out of the question. We've worked very hard > to eliminate its usage and get to an exclusively -blockdev based solution > because supporting both app

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Peter Krempa
On Mon, Sep 07, 2020 at 12:48:21 +0100, Daniel Berrange wrote: > On Mon, Sep 07, 2020 at 01:45:09PM +0200, Gerd Hoffmann wrote: > > Hi, [...] > > > 1. doing this transparently with a controller per device, just like the > > > usb-storage controller does internally (ok - it's just a scsi-cd ther

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Jan-Marek Glogowski
Hi Am 07.09.20 um 13:45 schrieb Gerd Hoffmann: >> -device nec-usb-xhci,id=xhci \ >> -device usb-bot,id=scsi0,bus=xhci.0 \ >> -device >> scsi-cd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,device_id=drive-scsi0-0-0-0,drive=libvirt-1-format,id=scsi0-0-0-0,bootindex=1 >> \ >> -device >> scsi-cd,bus=scsi0.0

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Daniel P . Berrangé
On Mon, Sep 07, 2020 at 01:45:09PM +0200, Gerd Hoffmann wrote: > Hi, > > > -device nec-usb-xhci,id=xhci \ > > -device usb-bot,id=scsi0,bus=xhci.0 \ > > -device > > scsi-cd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,device_id=drive-scsi0-0-0-0,drive=libvirt-1-format,id=scsi0-0-0-0,bootindex=1 > > \ >

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Gerd Hoffmann
Hi, > -device nec-usb-xhci,id=xhci \ > -device usb-bot,id=scsi0,bus=xhci.0 \ > -device > scsi-cd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,device_id=drive-scsi0-0-0-0,drive=libvirt-1-format,id=scsi0-0-0-0,bootindex=1 > \ > -device > scsi-cd,bus=scsi0.0,channel=0,scsi-id=0,lun=1,device_id=drive-scsi0

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-07 Thread Jan-Marek Glogowski
Am 07.09.20 um 08:04 schrieb Gerd Hoffmann: >> USB disks. The main problem is, that -blockdev mechanism relies >> on the device type to handle the media type, like ide-cd and >> ide-hd. But there is just usb-storage. > > You can use -device usb-bot + -device scsi-cd ... So I tried -blockdev '{"dr

Re: [PATCH 1/1] QEMU: support USB cdrom devices

2020-09-06 Thread Gerd Hoffmann
> USB disks. The main problem is, that -blockdev mechanism relies > on the device type to handle the media type, like ide-cd and > ide-hd. But there is just usb-storage. You can use -device usb-bot + -device scsi-cd ... take care, Gerd

[PATCH 1/1] QEMU: support USB cdrom devices

2020-09-06 Thread Jan-Marek Glogowski
If a USB cdrom is configured, the media type is silently ignored, when generating the QEMU command, so libvirt actually generates USB disks. The main problem is, that -blockdev mechanism relies on the device type to handle the media type, like ide-cd and ide-hd. But there is just usb-storage. As a