Re: [PATCH 2/2] qemu: Do not Use canonical path for system memory

2021-01-13 Thread Jiri Denemark
On Wed, Jan 13, 2021 at 08:06:30 +0100, Peter Krempa wrote: > On Tue, Jan 12, 2021 at 21:13:54 +0100, Jiri Denemark wrote: > > On Tue, Jan 12, 2021 at 20:21:19 +0100, Igor Mammedov wrote: > > > On Tue, 12 Jan 2021 09:29:50 +0100 > > > Michal Privoznik wrote: > > [...] > > > > > We consume machi

Re: [PATCH 2/2] qemu: Do not Use canonical path for system memory

2021-01-12 Thread Peter Krempa
On Tue, Jan 12, 2021 at 21:13:54 +0100, Jiri Denemark wrote: > On Tue, Jan 12, 2021 at 20:21:19 +0100, Igor Mammedov wrote: > > On Tue, 12 Jan 2021 09:29:50 +0100 > > Michal Privoznik wrote: [...] > > We consume machine types as opaque strings, we don't parse them and thus > we don't have any o

Re: [PATCH 2/2] qemu: Do not Use canonical path for system memory

2021-01-12 Thread Jiri Denemark
On Tue, Jan 12, 2021 at 20:21:19 +0100, Igor Mammedov wrote: > On Tue, 12 Jan 2021 09:29:50 +0100 > Michal Privoznik wrote: > > > In commit v6.9.0-rc1~450 I've adapted libvirt to QEMU's deprecation of > > -mem-path and -mem-prealloc and switched to memory-backend-* even for > > system memory. My

Re: [PATCH 2/2] qemu: Do not Use canonical path for system memory

2021-01-12 Thread Igor Mammedov
On Tue, 12 Jan 2021 09:29:50 +0100 Michal Privoznik wrote: > In commit v6.9.0-rc1~450 I've adapted libvirt to QEMU's deprecation of > -mem-path and -mem-prealloc and switched to memory-backend-* even for > system memory. My claim was that that's what QEMU does under the hood > anyway. And indeed

[PATCH 2/2] qemu: Do not Use canonical path for system memory

2021-01-12 Thread Michal Privoznik
In commit v6.9.0-rc1~450 I've adapted libvirt to QEMU's deprecation of -mem-path and -mem-prealloc and switched to memory-backend-* even for system memory. My claim was that that's what QEMU does under the hood anyway. And indeed it was: see QEMU commit v5.0.0-rc0~75^2~1^2~76 and look at function c