Re: [PATCH 3/3] lib: Require path in virDomainRestoreParams()

2022-05-13 Thread Claudio Fontana
On 5/13/22 9:28 AM, Michal Prívozník wrote: > On 5/12/22 19:09, Claudio Fontana wrote: >> Hello Michal, >> >> this seems to be going backwards to special case arguments instead of >> putting them into typed parameters. >> I do not understand where this need comes from, but it does not seem a good

Re: [PATCH 3/3] lib: Require path in virDomainRestoreParams()

2022-05-13 Thread Michal Prívozník
On 5/12/22 19:09, Claudio Fontana wrote: > Hello Michal, > > this seems to be going backwards to special case arguments instead of putting > them into typed parameters. > I do not understand where this need comes from, but it does not seem a good > direction to me. The need stems from my testin

Re: [PATCH 3/3] lib: Require path in virDomainRestoreParams()

2022-05-12 Thread Claudio Fontana
Hello Michal, this seems to be going backwards to special case arguments instead of putting them into typed parameters. I do not understand where this need comes from, but it does not seem a good direction to me. Thanks, Claudio On 5/12/22 5:17 PM, Michal Privoznik wrote: > After seeing previ

Re: [PATCH 3/3] lib: Require path in virDomainRestoreParams()

2022-05-12 Thread Michal Prívozník
On 5/12/22 17:22, Daniel P. Berrangé wrote: > On Thu, May 12, 2022 at 05:17:37PM +0200, Michal Privoznik wrote: >> After seeing previous commit one might think that >> virDomainRestoreParams() would get the similar treatment. Well, >> it can't. The problem here is: without any indication what domai

Re: [PATCH 3/3] lib: Require path in virDomainRestoreParams()

2022-05-12 Thread Daniel P . Berrangé
On Thu, May 12, 2022 at 05:17:37PM +0200, Michal Privoznik wrote: > After seeing previous commit one might think that > virDomainRestoreParams() would get the similar treatment. Well, > it can't. The problem here is: without any indication what domain > to restore we don't really know what domain t

[PATCH 3/3] lib: Require path in virDomainRestoreParams()

2022-05-12 Thread Michal Privoznik
After seeing previous commit one might think that virDomainRestoreParams() would get the similar treatment. Well, it can't. The problem here is: without any indication what domain to restore we don't really know what domain to restore (shocking, right?). Therefore, we have to require path to restor