Re: [PATCH 3/5] virDomainCheckpointRedefineCommit: Don't check ABI of definition in checkpoint

2020-12-04 Thread Daniel Henrique Barboza
On 12/2/20 11:13 AM, Peter Krempa wrote: Checking the definition ABI when redefining checkpoints doesn't make much sense for the following reasons: * the domain definition in the checkpoint is mostly unused (a relic adopted from the snapshot code) * can be very easily overriden by deletin

[PATCH 3/5] virDomainCheckpointRedefineCommit: Don't check ABI of definition in checkpoint

2020-12-02 Thread Peter Krempa
Checking the definition ABI when redefining checkpoints doesn't make much sense for the following reasons: * the domain definition in the checkpoint is mostly unused (a relic adopted from the snapshot code) * can be very easily overriden by deleting the checkpoint metadata before redefinition