Re: [PATCH 6/7] util: Check for pkttyagent availability properly

2021-12-13 Thread Martin Kletzander
On Mon, Dec 13, 2021 at 09:42:04AM -0700, Jim Fehlig wrote: On 12/12/21 14:15, Martin Kletzander wrote: On Sun, Dec 12, 2021 at 10:40:46AM -0700, Jim Fehlig wrote: On 12/11/21 03:28, Martin Kletzander wrote: On Sat, Dec 11, 2021 at 11:16:13AM +0100, Martin Kletzander wrote: On Fri, Dec 10, 20

Re: [PATCH 6/7] util: Check for pkttyagent availability properly

2021-12-12 Thread Martin Kletzander
On Sun, Dec 12, 2021 at 10:40:46AM -0700, Jim Fehlig wrote: On 12/11/21 03:28, Martin Kletzander wrote: On Sat, Dec 11, 2021 at 11:16:13AM +0100, Martin Kletzander wrote: On Fri, Dec 10, 2021 at 05:48:03PM -0700, Jim Fehlig wrote: Hi Martin! I recently received a bug report (sorry, not public

Re: [PATCH 6/7] util: Check for pkttyagent availability properly

2021-12-11 Thread Martin Kletzander
On Sat, Dec 11, 2021 at 11:16:13AM +0100, Martin Kletzander wrote: On Fri, Dec 10, 2021 at 05:48:03PM -0700, Jim Fehlig wrote: Hi Martin! I recently received a bug report (sorry, not public) about simple operations like 'virsh list' hanging when invoked with an internal test tool. I found this

Re: [PATCH 6/7] util: Check for pkttyagent availability properly

2021-12-11 Thread Martin Kletzander
On Fri, Dec 10, 2021 at 05:48:03PM -0700, Jim Fehlig wrote: Hi Martin! I recently received a bug report (sorry, not public) about simple operations like 'virsh list' hanging when invoked with an internal test tool. I found this commit to be the culprit. On 11/20/21 16:10, Martin Kletzander wrot

Re: [PATCH 6/7] util: Check for pkttyagent availability properly

2021-11-22 Thread Ján Tomko
On a Sunday in 2021, Martin Kletzander wrote: It does not need a tty to work, it opens its controlling terminal for user interaction and with this patch even crazy things like this work: echo 'list --name' | virsh -q >/dev/null Signed-off-by: Martin Kletzander --- src/util/virpolkit.c | 4 ++-

[PATCH 6/7] util: Check for pkttyagent availability properly

2021-11-20 Thread Martin Kletzander
It does not need a tty to work, it opens its controlling terminal for user interaction and with this patch even crazy things like this work: echo 'list --name' | virsh -q >/dev/null Signed-off-by: Martin Kletzander --- src/util/virpolkit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion