Re: [PATCH 7/7] qemu: Fix some issues in virQEMUDriverConfigLoadNVRAMEntry

2020-12-02 Thread Ján Tomko
On a Wednesday in 2020, John Ferlan wrote: Commit c4f4e195 fixed a double free, but if the code returns before we realloc the list and virFirmwareFreeList was called with cfg->nfirmwares 0 (e.g. during virQEMUDriverConfigDispose), then it would be rather disasterous. So let's reinitialze that t

[PATCH 7/7] qemu: Fix some issues in virQEMUDriverConfigLoadNVRAMEntry

2020-12-02 Thread John Ferlan
Commit c4f4e195 fixed a double free, but if the code returns before we realloc the list and virFirmwareFreeList was called with cfg->nfirmwares > 0 (e.g. during virQEMUDriverConfigDispose), then it would be rather disasterous. So let's reinitialze that too to indicate the list is empty. Coverity p