Re: [PATCH RESEND v1] xen: recognize device_model_override

2020-12-07 Thread Jim Fehlig
On 12/7/20 10:15 AM, Olaf Hering wrote: Am Thu, 19 Nov 2020 16:11:34 -0700 schrieb Jim Fehlig : On 11/19/20 12:58 PM, Olaf Hering wrote: Am Mon, 16 Nov 2020 19:48:28 -0700 schrieb Jim Fehlig : Correct. It is selected based on the specified and not modeled in domXML. Does it need to be expose

Re: [PATCH RESEND v1] xen: recognize device_model_override

2020-12-07 Thread Olaf Hering
Am Thu, 19 Nov 2020 16:11:34 -0700 schrieb Jim Fehlig : > On 11/19/20 12:58 PM, Olaf Hering wrote: > > Am Mon, 16 Nov 2020 19:48:28 -0700 > > schrieb Jim Fehlig : > >> Correct. It is selected based on the specified and not modeled > >> in > >> domXML. Does it need to be exposed to the user? AFAI

Re: [PATCH RESEND v1] xen: recognize device_model_override

2020-11-20 Thread Olaf Hering
Am Thu, 19 Nov 2020 16:11:34 -0700 schrieb Jim Fehlig : > I suppose. Currently it is done in the downstream OBS package in %check > VIR_TEST_DEBUG=1 %meson_test -t 5 --no-suite syntax-check I had to run the build in a chroot in a dom0, not sure why it happens to work elsewhere. With v2 of the pa

Re: [PATCH RESEND v1] xen: recognize device_model_override

2020-11-19 Thread Jim Fehlig
On 11/19/20 12:58 PM, Olaf Hering wrote: Am Mon, 16 Nov 2020 19:48:28 -0700 schrieb Jim Fehlig : Adjust the code to parse this as . You also have to adjust all the failing {xl,xm}configtests. It seems one has to run 'ninja test'. Yes. See https://libvirt.org/hacking.html Can this be done

Re: [PATCH RESEND v1] xen: recognize device_model_override

2020-11-19 Thread Olaf Hering
Am Mon, 16 Nov 2020 19:48:28 -0700 schrieb Jim Fehlig : > > Adjust the code to parse this as . > You also have to adjust all the failing {xl,xm}configtests. It seems one has to run 'ninja test'. Can this be done via _multibuild in a libvirt-testsuite pkg in an isolated VM? > Correct. It is sel

Re: [PATCH RESEND v1] xen: recognize device_model_override

2020-11-16 Thread Jim Fehlig
On 11/12/20 11:03 AM, Olaf Hering wrote: Since Xen 4.2 libxl expects device_model_override="/path" instead of device_model="/path". This has been on my todo list but never got the priority it deserved. Thanks for taking it on. Without your patch, using 'xl create' on xl.cfg converted from dom

[PATCH RESEND v1] xen: recognize device_model_override

2020-11-12 Thread Olaf Hering
Since Xen 4.2 libxl expects device_model_override="/path" instead of device_model="/path". Adjust the code to parse this as . While libxl also recognizes device_model_version="", this knob is not supported by libvirt. A runtime detection exists to select either "qemu-xen" or "qemu-xen-traditional".