Re: [PATCH for 8.5.0] qemu_hotplug: Don't skip cleanup in qemuDomainAttachNetDevice()

2022-07-01 Thread Michal Prívozník
On 7/1/22 10:43, Jiri Denemark wrote: > On Fri, Jul 01, 2022 at 09:43:16 +0200, Michal Privoznik wrote: >> Introduced in v8.4.0-rc1~183 but the first real problem >> introduced in v8.4.0-rc1~170, there's a >> qemuBuildInterfaceConnect() call inside of >> qemuDomainAttachNetDevice(). If the former f

Re: [PATCH for 8.5.0] qemu_hotplug: Don't skip cleanup in qemuDomainAttachNetDevice()

2022-07-01 Thread Jiri Denemark
On Fri, Jul 01, 2022 at 09:43:16 +0200, Michal Privoznik wrote: > Introduced in v8.4.0-rc1~183 but the first real problem > introduced in v8.4.0-rc1~170, there's a > qemuBuildInterfaceConnect() call inside of > qemuDomainAttachNetDevice(). If the former fails, then the > function is immediately ret

[PATCH for 8.5.0] qemu_hotplug: Don't skip cleanup in qemuDomainAttachNetDevice()

2022-07-01 Thread Michal Privoznik
Introduced in v8.4.0-rc1~183 but the first real problem introduced in v8.4.0-rc1~170, there's a qemuBuildInterfaceConnect() call inside of qemuDomainAttachNetDevice(). If the former fails, then the function is immediately returned from instead of jumping onto the cleanup label. This is crucial, bec