Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-21 Thread Peter Maydell
On Mon, 21 Sep 2020 at 15:58, Markus Armbruster wrote: > > Peter Maydell writes: > > If this only covers QMP, should we make the argument to -compat > > have a name that expresses that? eg deprecated-qmp-input, > > deprecated-qmp-output ? > > It's only implemented for QMP so far. But we really w

Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-21 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 14 Sep 2020 at 09:55, Markus Armbruster wrote: >> >> New option -compat lets you configure what to do when deprecated >> interfaces get used. This is intended for testing users of the >> management interfaces. It is experimental. >> >> -compat deprecated-input=

Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-21 Thread Richard W.M. Jones
On Mon, Sep 21, 2020 at 02:54:15PM +0200, Peter Krempa wrote: > On Mon, Sep 21, 2020 at 13:45:14 +0100, Richard W.M. Jones wrote: > > Some general comments on using the patch: > > > > * For libguestfs I chose to add > > > > -compat deprecated-input=reject,deprecated-output=hide > > > > This

Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-21 Thread Peter Maydell
On Mon, 14 Sep 2020 at 09:55, Markus Armbruster wrote: > > New option -compat lets you configure what to do when deprecated > interfaces get used. This is intended for testing users of the > management interfaces. It is experimental. > > -compat deprecated-input= configures what to do when > dep

Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-21 Thread Peter Krempa
On Mon, Sep 21, 2020 at 13:45:14 +0100, Richard W.M. Jones wrote: > Some general comments on using the patch: > > * For libguestfs I chose to add > > -compat deprecated-input=reject,deprecated-output=hide > > This is only enabled in developer builds of libguestfs when we > are running qemu

Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-21 Thread Richard W.M. Jones
Some general comments on using the patch: * For libguestfs I chose to add -compat deprecated-input=reject,deprecated-output=hide This is only enabled in developer builds of libguestfs when we are running qemu directly (not via libvirt). The patch for this is attached. * What's the poin

[PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-14 Thread Markus Armbruster
New option -compat lets you configure what to do when deprecated interfaces get used. This is intended for testing users of the management interfaces. It is experimental. -compat deprecated-input= configures what to do when deprecated input is received. Available policies: * accept: Accept dep