Re: Re: [PATCHv2 4/4] netlink: Introduce a helper function to simplify netlink functions

2021-01-06 Thread Shi Lei
On 2021-01-07 at 10:52, Shi Lei wrote: >On 2021-01-06 at 18:21, Michal Privoznik wrote: >>On 1/6/21 3:40 AM, Shi Lei wrote: >>> Extract common code as helper function virNetlinkTalk, then simplify >>> the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor]. >>> >>> -    default: >>> -   

Re: Re: [PATCHv2 4/4] netlink: Introduce a helper function to simplify netlink functions

2021-01-06 Thread Shi Lei
On 2021-01-06 at 18:21, Michal Privoznik wrote: >On 1/6/21 3:40 AM, Shi Lei wrote: >> Extract common code as helper function virNetlinkTalk, then simplify >> the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor]. >> >> Signed-off-by: Shi Lei >> --- >>   src/util/virnetlink.c | 225 +++

Re: [PATCHv2 4/4] netlink: Introduce a helper function to simplify netlink functions

2021-01-06 Thread Michal Privoznik
On 1/6/21 3:40 AM, Shi Lei wrote: Extract common code as helper function virNetlinkTalk, then simplify the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor]. Signed-off-by: Shi Lei --- src/util/virnetlink.c | 225 +- src/util/virnetlink.h |

[PATCHv2 4/4] netlink: Introduce a helper function to simplify netlink functions

2021-01-05 Thread Shi Lei
Extract common code as helper function virNetlinkTalk, then simplify the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor]. Signed-off-by: Shi Lei --- src/util/virnetlink.c | 225 +- src/util/virnetlink.h | 4 +- 2 files changed, 94 insertions(+