Re: [PATCHv3 4/4] netlink: Introduce a helper function to simplify netlink functions

2021-01-15 Thread Michal Privoznik
On 1/13/21 12:51 PM, Michal Privoznik wrote: On 1/12/21 2:29 AM, Shi Lei wrote: On 2021-01-11 at 19:26, Michal Privoznik wrote: On 1/11/21 3:23 AM, Shi Lei wrote: Extract common code as helper function virNetlinkTalk, then simplify the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor]

Re: [PATCHv3 4/4] netlink: Introduce a helper function to simplify netlink functions

2021-01-13 Thread Michal Privoznik
On 1/12/21 2:29 AM, Shi Lei wrote: On 2021-01-11 at 19:26, Michal Privoznik wrote: On 1/11/21 3:23 AM, Shi Lei wrote: Extract common code as helper function virNetlinkTalk, then simplify the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor]. Signed-off-by: Shi Lei ---    src/util/vi

Re: Re: [PATCHv3 4/4] netlink: Introduce a helper function to simplify netlink functions

2021-01-11 Thread Shi Lei
On 2021-01-11 at 19:26, Michal Privoznik wrote: >On 1/11/21 3:23 AM, Shi Lei wrote: >> Extract common code as helper function virNetlinkTalk, then simplify >> the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor]. >> >> Signed-off-by: Shi Lei >> --- >>   src/util/virnetlink.c | 232 ++

Re: [PATCHv3 4/4] netlink: Introduce a helper function to simplify netlink functions

2021-01-11 Thread Michal Privoznik
On 1/11/21 3:23 AM, Shi Lei wrote: Extract common code as helper function virNetlinkTalk, then simplify the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor]. Signed-off-by: Shi Lei --- src/util/virnetlink.c | 232 ++ src/util/virnetlink.h |

[PATCHv3 4/4] netlink: Introduce a helper function to simplify netlink functions

2021-01-10 Thread Shi Lei
Extract common code as helper function virNetlinkTalk, then simplify the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor]. Signed-off-by: Shi Lei --- src/util/virnetlink.c | 232 ++ src/util/virnetlink.h | 4 +- 2 files changed, 101 insertions(