Re: [RFC] qemu_migration: Fix virConnectOpenAuth error code

2022-01-06 Thread Ani Sinha
On Thu, 6 Jan 2022, Michal Prívozník wrote: > On 1/6/22 13:42, Ani Sinha wrote: > > > > > > On Thu, 6 Jan 2022, Michal Prívozník wrote: > > > >> On 1/6/22 02:33, Raphael Norwitz wrote: > >>> Today if virConnectOpenAuth fails, qemuMigrationSrcPerformPeer2Peer() > >>> returns VIR_ERR_OPERATION_FAI

Re: [RFC] qemu_migration: Fix virConnectOpenAuth error code

2022-01-06 Thread Michal Prívozník
On 1/6/22 13:42, Ani Sinha wrote: > > > On Thu, 6 Jan 2022, Michal Prívozník wrote: > >> On 1/6/22 02:33, Raphael Norwitz wrote: >>> Today if virConnectOpenAuth fails, qemuMigrationSrcPerformPeer2Peer() >>> returns VIR_ERR_OPERATION_FAILED. This change switches that error code >>> to VIR_ERR_NO_

Re: [RFC] qemu_migration: Fix virConnectOpenAuth error code

2022-01-06 Thread Ani Sinha
On Thu, 6 Jan 2022, Michal Prívozník wrote: > On 1/6/22 02:33, Raphael Norwitz wrote: > > Today if virConnectOpenAuth fails, qemuMigrationSrcPerformPeer2Peer() > > returns VIR_ERR_OPERATION_FAILED. This change switches that error code > > to VIR_ERR_NO_CONNECT, which is more accurate. > > > > Th

Re: [RFC] qemu_migration: Fix virConnectOpenAuth error code

2022-01-06 Thread Michal Prívozník
On 1/6/22 02:33, Raphael Norwitz wrote: > Today if virConnectOpenAuth fails, qemuMigrationSrcPerformPeer2Peer() > returns VIR_ERR_OPERATION_FAILED. This change switches that error code > to VIR_ERR_NO_CONNECT, which is more accurate. > > This should help libvirt consumers more intellegently retry

Re: [RFC] qemu_migration: Fix virConnectOpenAuth error code

2022-01-06 Thread Ani Sinha
On Thu, 6 Jan 2022, Raphael Norwitz wrote: > Today if virConnectOpenAuth fails, qemuMigrationSrcPerformPeer2Peer() > returns VIR_ERR_OPERATION_FAILED. This change switches that error code > to VIR_ERR_NO_CONNECT, which is more accurate. Hmm, I am not sure if this would be the right thing. virC

[RFC] qemu_migration: Fix virConnectOpenAuth error code

2022-01-06 Thread Raphael Norwitz
Today if virConnectOpenAuth fails, qemuMigrationSrcPerformPeer2Peer() returns VIR_ERR_OPERATION_FAILED. This change switches that error code to VIR_ERR_NO_CONNECT, which is more accurate. This should help libvirt consumers more intellegently retry migrations on intermittent connection failures. C