Re: [RFC PATCH 1/6] compatibilities: added in flags for NFS support

(answering for Peter since he is on "vacation", so it may be awhile before he gets around to this) On 12/14/20 5:54 PM, Ryan Gahagan wrote: On Fri, Dec 11, 2020 at 3:35 AM Peter Krempa > wrote: In subject/summary. We don't have anything which we'd prefix with

Re: [RFC PATCH 1/6] compatibilities: added in flags for NFS support

On Fri, Dec 11, 2020 at 3:35 AM Peter Krempa wrote: > In subject/summary. We don't have anything which we'd prefix with > 'compatibilities:'. Just to confirm, does this mean that we should not implement the feedback Han Han suggested about the NFS capability flags and instead leave the commit a

Re: [RFC PATCH 1/6] compatibilities: added in flags for NFS support

On Thu, Dec 10, 2020 at 14:00:02 -0600, Ryan Gahagan wrote: In subject/summary. We don't have anything which we'd prefix with 'compatibilities:'. A better summary will be: conf: Add NFS disk protocol > Signed-off-by: Ryan Gahagan > --- > src/libxl/libxl_conf.c| 1 + > src/libxl/xen_xl.c

Re: [RFC PATCH 1/6] compatibilities: added in flags for NFS support

On Fri, Dec 11, 2020 at 4:01 AM Ryan Gahagan wrote: > Signed-off-by: Ryan Gahagan > --- > The patch for compatibilities usually is on src/qemu/qemu_capabilities* and tests/qemucapabilitiesdata/caps_*. Because nfs disk is supported since qemu v2.9( https://github.com/qemu/qemu/blob/master/qapi/bl

[RFC PATCH 1/6] compatibilities: added in flags for NFS support

Signed-off-by: Ryan Gahagan --- src/libxl/libxl_conf.c| 1 + src/libxl/xen_xl.c| 1 + src/qemu/qemu_block.c | 3 +++ src/qemu/qemu_command.c | 1 + src/qemu/qemu_domain.c| 2 ++ src/qemu/qemu_snapshot.c | 3 +++ src/util/virstoragefile.c | 6 ++ src/util/virstoragefile.