Re: [libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-06-06 Thread Peter Krempa
On Fri, Jun 03, 2022 at 16:43:30 +0200, Michal Prívozník wrote: > On 6/3/22 09:36, Peter Krempa wrote: > > On Thu, Jun 02, 2022 at 22:49:15 +, Yang, Lin A wrote: > >> On 6/2/22, 11:28 AM, "Yang, Lin A" wrote: > >>> On 6/1/22, 11:37 PM, "Michal Prívozník" wrote: [...] > Exactly. This is what

Re: [libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-06-03 Thread Michal Prívozník
On 6/3/22 09:36, Peter Krempa wrote: > On Thu, Jun 02, 2022 at 22:49:15 +, Yang, Lin A wrote: >> On 6/2/22, 11:28 AM, "Yang, Lin A" wrote: >>> On 6/1/22, 11:37 PM, "Michal Prívozník" wrote: > > [...] > So maybe in the end libvirt CAN know the difference without having to do any ve

Re: [libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-06-03 Thread Peter Krempa
On Thu, Jun 02, 2022 at 22:49:15 +, Yang, Lin A wrote: > On 6/2/22, 11:28 AM, "Yang, Lin A" wrote: > > On 6/1/22, 11:37 PM, "Michal Prívozník" wrote: [...] > > > So maybe in the end libvirt CAN know the difference without having to do > > > any version check. We have a "dialect" of XPATH th

Re: [libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-06-02 Thread Yang, Lin A
On 6/2/22, 11:28 AM, "Yang, Lin A" wrote: > On 6/1/22, 11:37 PM, "Michal Prívozník" wrote: > > Worst case scenario we can do a version check. It's very suboptimal > > because if somebody backports your patches in QEMU, libvirt will stop > > working despite having the version check. > > > > Theref

Re: [libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-06-02 Thread Yang, Lin A
On 6/1/22, 11:37 PM, "Michal Prívozník" wrote: > Worst case scenario we can do a version check. It's very suboptimal > because if somebody backports your patches in QEMU, libvirt will stop > working despite having the version check. > > Therefore, I'm more inclined to just use the newest API and

Re: [libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-06-01 Thread Michal Prívozník
On 6/2/22 02:52, Yang, Lin A wrote: > On 5/31/22, 7:29 AM, "Michal Prívozník" wrote: > > >   > >> 2) apparently, .node attribute is required? Now, it's true that > >> initially my guest has 2 NUMA nodes defined, but even after I remove > >> those I still see the error. I believe I've raised

Re: [libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-06-01 Thread Yang, Lin A
On 5/31/22, 7:29 AM, "Michal Prívozník" wrote: > So, now that I've cleaned up the code I can start to test it, but > unfortunately, I don't have good news. It's not working. I've put the > following into my domain XML: > > > > 16384 > > > > and this is the generated

Re: [libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-05-31 Thread Michal Prívozník
On 5/30/22 15:09, Michal Prívozník wrote: > On 5/18/22 09:59, Haibin Huang wrote: >> > > Overall, these patches work. I've raised couple of points and for your > convenience you can find reworked patches here: > > https://gitlab.com/MichalPrivoznik/libvirt/-/commits/sgx_fixups/ > > Please see in

Re: [libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-05-30 Thread Michal Prívozník
On 5/18/22 09:59, Haibin Huang wrote: > Overall, these patches work. I've raised couple of points and for your convenience you can find reworked patches here: https://gitlab.com/MichalPrivoznik/libvirt/-/commits/sgx_fixups/ Please see individual patches for comments. Michal

[libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-05-18 Thread Haibin Huang
This patch series provides support for enabling Intel's Software Guard Extensions (SGX) feature in guest VM. Giving the SGX support in QEMU had been merged. Intel SGX is a set of instructions that increases the security of application code and data, giving them more protection from disclosure o