Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-03-16 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 11:01:10AM -0400, Dave Allan wrote: > On 03/16/2010 06:22 AM, Daniel P. Berrange wrote: > >On Mon, Mar 15, 2010 at 05:21:26PM -0400, Dave Allan wrote: > >> > >>Now that 0.7.7 is done, we need to revisit fs pool building. > >> > >>Because it is impossible to implement a check

Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-03-16 Thread Dave Allan
On 03/16/2010 06:22 AM, Daniel P. Berrange wrote: On Mon, Mar 15, 2010 at 05:21:26PM -0400, Dave Allan wrote: Now that 0.7.7 is done, we need to revisit fs pool building. Because it is impossible to implement a check for arbitrary existing data, the only safe option is to require the overwrite

Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-03-16 Thread Daniel P. Berrange
On Mon, Mar 15, 2010 at 05:21:26PM -0400, Dave Allan wrote: > > Now that 0.7.7 is done, we need to revisit fs pool building. > > Because it is impossible to implement a check for arbitrary existing > data, the only safe option is to require the overwrite flag in all > cases. If we do not requi

Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-03-15 Thread Dave Allan
On 02/26/2010 06:28 PM, Dave Allan wrote: On 02/26/2010 06:23 AM, Daniel P. Berrange wrote: On Thu, Feb 25, 2010 at 10:01:09PM -0500, Dave Allan wrote: On 02/25/2010 08:25 AM, Daniel P. Berrange wrote: On Thu, Feb 25, 2010 at 01:19:54PM +0100, Daniel Veillard wrote: On Wed, Feb 24, 2010 at 03

Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-02-26 Thread Dave Allan
On 02/26/2010 06:23 AM, Daniel P. Berrange wrote: On Thu, Feb 25, 2010 at 10:01:09PM -0500, Dave Allan wrote: On 02/25/2010 08:25 AM, Daniel P. Berrange wrote: On Thu, Feb 25, 2010 at 01:19:54PM +0100, Daniel Veillard wrote: On Wed, Feb 24, 2010 at 03:51:45PM -0500, Cole Robinson wrote: Hi gu

Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-02-26 Thread Daniel P. Berrange
On Thu, Feb 25, 2010 at 10:01:09PM -0500, Dave Allan wrote: > On 02/25/2010 08:25 AM, Daniel P. Berrange wrote: > >On Thu, Feb 25, 2010 at 01:19:54PM +0100, Daniel Veillard wrote: > >>On Wed, Feb 24, 2010 at 03:51:45PM -0500, Cole Robinson wrote: > >>>Hi guys, > >>> > >>>Looking at the new FS pool

Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-02-25 Thread Dave Allan
On 02/25/2010 08:25 AM, Daniel P. Berrange wrote: On Thu, Feb 25, 2010 at 01:19:54PM +0100, Daniel Veillard wrote: On Wed, Feb 24, 2010 at 03:51:45PM -0500, Cole Robinson wrote: Hi guys, Looking at the new FS pool build options and talking with Dave, I see that calling PoolBuild on an FS pool

Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-02-25 Thread Cole Robinson
On 02/25/2010 09:55 AM, Cole Robinson wrote: > On 02/25/2010 08:25 AM, Daniel P. Berrange wrote: >> On Thu, Feb 25, 2010 at 01:19:54PM +0100, Daniel Veillard wrote: >>> On Wed, Feb 24, 2010 at 03:51:45PM -0500, Cole Robinson wrote: Hi guys, Looking at the new FS pool build options an

Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-02-25 Thread Cole Robinson
On 02/25/2010 08:25 AM, Daniel P. Berrange wrote: > On Thu, Feb 25, 2010 at 01:19:54PM +0100, Daniel Veillard wrote: >> On Wed, Feb 24, 2010 at 03:51:45PM -0500, Cole Robinson wrote: >>> Hi guys, >>> >>> Looking at the new FS pool build options and talking with Dave, I see that >>> calling PoolBuil

Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-02-25 Thread Daniel P. Berrange
On Thu, Feb 25, 2010 at 01:19:54PM +0100, Daniel Veillard wrote: > On Wed, Feb 24, 2010 at 03:51:45PM -0500, Cole Robinson wrote: > > Hi guys, > > > > Looking at the new FS pool build options and talking with Dave, I see that > > calling PoolBuild on an FS pool now unconditionally calls mkfs. This

Re: [libvirt] 'build' on FS pool now unconditionally formats?

2010-02-25 Thread Daniel Veillard
On Wed, Feb 24, 2010 at 03:51:45PM -0500, Cole Robinson wrote: > Hi guys, > > Looking at the new FS pool build options and talking with Dave, I see that > calling PoolBuild on an FS pool now unconditionally calls mkfs. This is really > bad when mixed with virt-manager: previously, we assumed the F

[libvirt] 'build' on FS pool now unconditionally formats?

2010-02-24 Thread Cole Robinson
Hi guys, Looking at the new FS pool build options and talking with Dave, I see that calling PoolBuild on an FS pool now unconditionally calls mkfs. This is really bad when mixed with virt-manager: previously, we assumed the FS build command was always non destructive (at most it created a director