bindings][PATCH] Add/Clean comments and
virConnecSetErrorFunc Sample
Your patches in general are okay, no problem with that. :)
It's just that this patch contains 3 independent changes. As a general
rule of thumb you should do one thing per commit. This makes things
simpler to review
the well word.
>
> Can you explain me what is a "good" patch, just for make less work for you ?
>
> Regards,
>
> Arnaud
>
> --
> From: "Matthias Bolte"
> Sent: Monday, November 01, 201
m: "Matthias Bolte"
Sent: Monday, November 01, 2010 7:15 PM
To:
Cc:
Subject: Re: [libvirt] [C# bindings][PATCH] Add/Clean comments and
virConnecSetErrorFunc Sample
2010/10/30 :
Hi,
here is a new patch, it add/correct some comments. It also make
virDomainInfo marshalin
2010/10/30 :
> Hi,
>
> here is a new patch, it add/correct some comments. It also make
> virDomainInfo marshaling working. It also add a new sample
> virConnectSetErrorFunc to show usage of virConnectSetErrorFunc, virError
> struct, virDomainInfo struct.
>
> Regards,
>
> Arnaud
>
Actually this pa
