Daniel Veillard wrote:
> Seems fixed now, I'm seeing
>
> case VIR_DOMAIN_GRAPHICS_TYPE_VNC:
> if (def->data.vnc.port &&
> (!def->data.vnc.autoport || vm->id != -1))
> virBufferVSprintf(buf, " port='%d'",
> def->data.vnc.port);
>
On Thu, Jul 31, 2008 at 02:17:25PM +0100, Daniel P. Berrange wrote:
> On Thu, Jul 31, 2008 at 02:24:25PM +0200, Chris Lalancette wrote:
> > Daniel Veillard wrote:
> > >> So the explicit port is output in XML if autoport is not set, or
> > >> if the domain is running.
> > >
> > > Okay +1, push th
On Thu, Jul 31, 2008 at 02:24:25PM +0200, Chris Lalancette wrote:
> Daniel Veillard wrote:
> >> So the explicit port is output in XML if autoport is not set, or
> >> if the domain is running.
> >
> > Okay +1, push the patch :-)
>
> Yes, I agree, I just tested out the patch and it seems to fix t
Daniel Veillard wrote:
>> So the explicit port is output in XML if autoport is not set, or
>> if the domain is running.
>
> Okay +1, push the patch :-)
Yes, I agree, I just tested out the patch and it seems to fix the issue for me.
I'm going to commit the patch now.
Chris Lalancette
--
Libvi
On Wed, Jul 30, 2008 at 10:43:35AM +0100, Daniel P. Berrange wrote:
> On Wed, Jul 30, 2008 at 05:33:22AM -0400, Daniel Veillard wrote:
> > On Wed, Jul 30, 2008 at 10:17:59AM +0100, Daniel P. Berrange wrote:
> > > Forwarding message that was sent to wrong list...
> >
> > Hum, that sounds right, t
On Wed, Jul 30, 2008 at 05:33:22AM -0400, Daniel Veillard wrote:
> On Wed, Jul 30, 2008 at 10:17:59AM +0100, Daniel P. Berrange wrote:
> > Forwarding message that was sent to wrong list...
>
> Hum, that sounds right, the logic got twisted, the presence of
> a defined port should otherride the au
On Wed, Jul 30, 2008 at 10:17:59AM +0100, Daniel P. Berrange wrote:
> Forwarding message that was sent to wrong list...
Hum, that sounds right, the logic got twisted, the presence of
a defined port should otherride the autoport settings, right ?
Daniel
> > case VIR_DOMAIN_GRAPHICS_TYPE_VN
Forwarding message that was sent to wrong list...
- Forwarded message from Charles Duffy <[EMAIL PROTECTED]> -
> To: [EMAIL PROTECTED]
> From: Charles Duffy <[EMAIL PROTECTED]>
> Subject: [PATCH] autoport overrides actual VNC port number in dump-xml
> Date: Wed, 30 Jul 2008 00:32
