Re: [libvirt] [PATCH/RFC]: don't ignore errors to save the domain status file

2009-02-07 Thread Guido Günther
On Thu, Feb 05, 2009 at 06:49:52PM +0100, Jim Meyering wrote: > Guido Günther wrote: > > we currently don't report errors to save qemu's domain status file back > > to the caller. That was o.k. as long as the code was there for testing > > but now that the XML is being picked up on daemon restart

Re: [libvirt] [PATCH/RFC]: don't ignore errors to save the domain status file

2009-02-05 Thread Jim Meyering
Guido Günther wrote: > we currently don't report errors to save qemu's domain status file back > to the caller. That was o.k. as long as the code was there for testing > but now that the XML is being picked up on daemon restart we must > handle these. > The attached patch does that, although I'm n

Re: [libvirt] [PATCH/RFC]: don't ignore errors to save the domain status file

2009-02-05 Thread Daniel P. Berrange
On Sat, Jan 31, 2009 at 02:32:09PM +0100, Guido G?nther wrote: > Hi, > we currently don't report errors to save qemu's domain status file back > to the caller. That was o.k. as long as the code was there for testing > but now that the XML is being picked up on daemon restart we must > handle these.

Re: [libvirt] [PATCH/RFC]: don't ignore errors to save the domain status file

2009-02-05 Thread Guido Günther
On Sat, Jan 31, 2009 at 02:32:09PM +0100, Guido Günther wrote: > we currently don't report errors to save qemu's domain status file back > to the caller. That was o.k. as long as the code was there for testing > but now that the XML is being picked up on daemon restart we must > handle these. Any c

[libvirt] [PATCH/RFC]: don't ignore errors to save the domain status file

2009-01-31 Thread Guido Günther
Hi, we currently don't report errors to save qemu's domain status file back to the caller. That was o.k. as long as the code was there for testing but now that the XML is being picked up on daemon restart we must handle these. The attached patch does that, although I'm not confident that it's enoug