Re: [libvirt] [PATCH]: Add floppy support to xm_internal

2008-07-18 Thread Daniel P. Berrange
On Fri, Jul 18, 2008 at 05:31:27PM +0100, John Levon wrote: > On Fri, Jul 18, 2008 at 02:05:06PM +0200, Chris Lalancette wrote: > > > What this actually means is that we shouldn't parse the floppy stuff to put > > it > > in the "disks =" section of the /etc/xen configuration file, since it > > d

Re: [libvirt] [PATCH]: Add floppy support to xm_internal

2008-07-18 Thread John Levon
On Fri, Jul 18, 2008 at 02:05:06PM +0200, Chris Lalancette wrote: > What this actually means is that we shouldn't parse the floppy stuff to put it > in the "disks =" section of the /etc/xen configuration file, since it doesn't > have meaning there. Instead, floppy disks go at the top-level of a X

Re: [libvirt] [PATCH]: Add floppy support to xm_internal

2008-07-18 Thread Chris Lalancette
Daniel P. Berrange wrote: > Sorry, this patch is no use - there is a stack of patches pending review > which re-write the XM and XenD driver's XML handling from scratch to use > the new generic domain XML APIs. The floppy stuff will have to stack on > top of that: That's OK; the same general idea

Re: [libvirt] [PATCH]: Add floppy support to xm_internal

2008-07-18 Thread Daniel P. Berrange
On Fri, Jul 18, 2008 at 02:05:06PM +0200, Chris Lalancette wrote: > Yes, you read the subject right; add floppy support to xm internal. Let's > just > say I didn't do this by choice. In any case, there was a cryptic comment in > xenXMParseXMLDisks() that said: > > /* Xend (all versions) put the

[libvirt] [PATCH]: Add floppy support to xm_internal

2008-07-18 Thread Chris Lalancette
Yes, you read the subject right; add floppy support to xm internal. Let's just say I didn't do this by choice. In any case, there was a cryptic comment in xenXMParseXMLDisks() that said: /* Xend (all versions) put the floppy device config * under the hvm (image (os)) block */ What this actual