On Mon, Nov 03, 2008 at 12:38:49PM +0100, Chris Lalancette wrote:
> Daniel P. Berrange wrote:
>
> Oops, of course. I've fixed this up and committed the result; the final patch
> is attached.
>
> Thanks for the review,
>
> --
> Chris Lalancette
> Index: src/storage_backend.c
>
Daniel P. Berrange wrote:
>> diff -u -r1.24 storage_backend.c
>> --- src/storage_backend.c28 Oct 2008 17:48:06 - 1.24
>> +++ src/storage_backend.c31 Oct 2008 11:56:33 -
>> @@ -357,7 +357,7 @@
>> char *
>> virStorageBackendStablePath(virConnectPtr conn,
>>
On Fri, Oct 31, 2008 at 12:58:17PM +0100, Chris Lalancette wrote:
> Daniel P. Berrange wrote:
> >> Personally, I think those are bad semantics for
> >> virStorageBackendStablePath;
> >> assuming it succeeds, you should always be able to know that you have a
> >> copy,
> >> regardless of whether t
Daniel P. Berrange wrote:
>> Personally, I think those are bad semantics for virStorageBackendStablePath;
>> assuming it succeeds, you should always be able to know that you have a copy,
>> regardless of whether the copy is the same as the original. Should I change
>> virStorageBackendStablePath t
On Fri, Oct 31, 2008 at 12:26:17PM +0100, Chris Lalancette wrote:
> Daniel P. Berrange wrote:
> > On Fri, Oct 31, 2008 at 12:04:34PM +0100, Chris Lalancette wrote:
> >> Index: src/storage_driver.c
> >> ===
> >> RCS file: /data/cvs/libv
Daniel P. Berrange wrote:
> On Fri, Oct 31, 2008 at 12:04:34PM +0100, Chris Lalancette wrote:
>> Index: src/storage_driver.c
>> ===
>> RCS file: /data/cvs/libvirt/src/storage_driver.c,v
>> retrieving revision 1.13
>> diff -u -r1.13 sto
On Fri, Oct 31, 2008 at 12:04:34PM +0100, Chris Lalancette wrote:
> Index: src/storage_driver.c
> ===
> RCS file: /data/cvs/libvirt/src/storage_driver.c,v
> retrieving revision 1.13
> diff -u -r1.13 storage_driver.c
> --- a/src/storage
In ovirt, we have to scan iSCSI LUN's for LVM storage when they are first added
to the database. To do this, we do roughly the following:
iscsi_pool = libvirt.define_and_start_iscsi_pool("/dev/disk/by-id")
iscsi_pool.add_luns_to_db
logical = conn.discover_storage_pool_sources("logical")
for each
