Re: [libvirt] [PATCH]: ruby-libvirt migration fixes

2008-08-12 Thread David Lutterkort
On Fri, 2008-08-08 at 16:22 +0200, Chris Lalancette wrote: > Jim Meyering wrote: > >> diff -r c6a3e36cdf54 ext/libvirt/_libvirt.c > >> --- a/ext/libvirt/_libvirt.c Thu Jul 17 15:24:26 2008 -0700 > >> +++ b/ext/libvirt/_libvirt.c Fri Aug 08 06:04:56 2008 -0400 > >> @@ -637,16 +637,51 @@

Re: [libvirt] [PATCH]: ruby-libvirt migration fixes

2008-08-08 Thread Jim Meyering
Chris Lalancette <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >>> diff -r c6a3e36cdf54 ext/libvirt/_libvirt.c >>> --- a/ext/libvirt/_libvirt.cThu Jul 17 15:24:26 2008 -0700 >>> +++ b/ext/libvirt/_libvirt.cFri Aug 08 06:04:56 2008 -0400 >>> @@ -637,16 +637,51 @@ VALUE libvirt_con

Re: [libvirt] [PATCH]: ruby-libvirt migration fixes

2008-08-08 Thread Chris Lalancette
Jim Meyering wrote: >> diff -r c6a3e36cdf54 ext/libvirt/_libvirt.c >> --- a/ext/libvirt/_libvirt.c Thu Jul 17 15:24:26 2008 -0700 >> +++ b/ext/libvirt/_libvirt.c Fri Aug 08 06:04:56 2008 -0400 >> @@ -637,16 +637,51 @@ VALUE libvirt_conn_num_of_defined_storag >> } >> #endif >> >> +static char *get

Re: [libvirt] [PATCH]: ruby-libvirt migration fixes

2008-08-08 Thread Jim Meyering
Chris Lalancette <[EMAIL PROTECTED]> wrote: > Attached is a relatively simple patch to the ruby-libvirt bindings with some > bugfixes for the migrate call. The first problem was that there was no way to > pass a "nil" through to the underlying virDomainMigrate() call. This is > important because

[libvirt] [PATCH]: ruby-libvirt migration fixes

2008-08-08 Thread Chris Lalancette
Attached is a relatively simple patch to the ruby-libvirt bindings with some bugfixes for the migrate call. The first problem was that there was no way to pass a "nil" through to the underlying virDomainMigrate() call. This is important because generally the "dname" and "uri" parameters end up be