Re: [libvirt] [PATCH] Add actions to virDomainLifecycle enum

2010-08-20 Thread Jim Fehlig
Eric Blake wrote: > On 08/12/2010 11:15 AM, Jim Fehlig wrote: > +++ b/src/conf/domain_conf.c @@ -81,7 +81,9 @@ VIR_ENUM_IMPL(virDomainLifecycle, VIR_DOMAIN_LIFECYCLE_LAST, "destroy", "restart", "rename-restart", -

Re: [libvirt] [PATCH] Add actions to virDomainLifecycle enum

2010-08-20 Thread Eric Blake
On 08/12/2010 11:15 AM, Jim Fehlig wrote: >>> +++ b/src/conf/domain_conf.c >>> @@ -81,7 +81,9 @@ VIR_ENUM_IMPL(virDomainLifecycle, >>> VIR_DOMAIN_LIFECYCLE_LAST, >>>"destroy", >>>"restart", >>>"rename-restart", >>> - "preserve") >>> +

Re: [libvirt] [PATCH] Add actions to virDomainLifecycle enum

2010-08-20 Thread Jim Fehlig
Jim Fehlig wrote: > Eric Blake wrote: > >> Hmm. These two new values are only valid for on_crash, but I don't see >> any code that rejects them for on_reboot or on_poweroff. Do we need a >> separate enum here, or do we just need to add better checking to the >> remaining clients to detect enum

Re: [libvirt] [PATCH] Add actions to virDomainLifecycle enum

2010-08-12 Thread Jim Fehlig
Eric Blake wrote: >> + >> + on_crash supports these additional actions. >> > > Should we add a 0.8.4 tag here? > Hmm, not sure. None of the existing lifecycle documentation contains tags. >> +++ b/src/conf/domain_conf.c >> @@ -81,7 +81,9 @@ VIR_ENUM_IMPL(virDomainLifecycle, >>

Re: [libvirt] [PATCH] Add actions to virDomainLifecycle enum

2010-08-10 Thread Eric Blake
On 07/29/2010 03:54 PM, Jim Fehlig wrote: > I'm not too fond of the schema change but thus far haven't found a way > to condense it. Suggestions welcomed :-). I don't see any of DV's promised comments, and it obviously didn't make it into 0.8.3 :( >>From a27589eb861fd487cb07e537b5da25125599e8a5

Re: [libvirt] [PATCH] Add actions to virDomainLifecycle enum

2010-08-04 Thread Daniel Veillard
On Mon, Aug 02, 2010 at 02:04:37PM -0600, Jim Fehlig wrote: > Any opinions on this patch? Possible for 0.8.3? Whoops ... I missed it, sorry ! Will give feedback tomorrow ... Daniel > Jim Fehlig wrote: > > I'm not too fond of the schema change but thus far haven't found a way > > to condense i

Re: [libvirt] [PATCH] Add actions to virDomainLifecycle enum

2010-08-02 Thread Jim Fehlig
Any opinions on this patch? Possible for 0.8.3? Thanks, Jim Jim Fehlig wrote: > I'm not too fond of the schema change but thus far haven't found a way > to condense it. Suggestions welcomed :-). > > Regards, > Jim > > > ---

[libvirt] [PATCH] Add actions to virDomainLifecycle enum

2010-07-29 Thread Jim Fehlig
I'm not too fond of the schema change but thus far haven't found a way to condense it. Suggestions welcomed :-). Regards, Jim >From a27589eb861fd487cb07e537b5da25125599e8a5 Mon Sep 17 00:00:00 2001 From: Jim Fehlig Date: Thu, 29 Jul 2010 12:21:47 -0600 Subject: [PATCH] Add actions to virDomainL