Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-30 Thread Michal Novotny
> On 03/30/2011 01:00 PM, Michal Novotny wrote: >>> I think you should triage it a bit more, e.g. with strace -ff. Anyway, >>> there is no hurry of doing this I think. >> Well, you mean to use strace on the daemonized process? > Wherever it helps understanding what's happening. :) > Also, I'v

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-30 Thread Michal Novotny
> On 03/30/2011 01:00 PM, Michal Novotny wrote: >>> I think you should triage it a bit more, e.g. with strace -ff. Anyway, >>> there is no hurry of doing this I think. >> Well, you mean to use strace on the daemonized process? > Wherever it helps understanding what's happening. :) It was a good

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-30 Thread Michal Novotny
> On 03/30/2011 01:00 PM, Michal Novotny wrote: >>> I think you should triage it a bit more, e.g. with strace -ff. Anyway, >>> there is no hurry of doing this I think. >> Well, you mean to use strace on the daemonized process? > Wherever it helps understanding what's happening. :) > Also, I'v

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-30 Thread Paolo Bonzini
On 03/30/2011 01:00 PM, Michal Novotny wrote: I think you should triage it a bit more, e.g. with strace -ff. Anyway, there is no hurry of doing this I think. Well, you mean to use strace on the daemonized process? Wherever it helps understanding what's happening. :) Also, I've been testing

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-30 Thread Michal Novotny
> On 03/30/2011 12:41 PM, Michal Novotny wrote: >> 1) /usr/sbin/dnsmasq --strict-order --bind-interfaces >> --pid-file=/var/run/libvirt/network/default.pid --conf-file= >> --except-interface lo --txt-record="txt-record","some value, which is >> something" --addn-hosts=/var/run/libvirt/network/defau

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-30 Thread Paolo Bonzini
On 03/30/2011 12:41 PM, Michal Novotny wrote: 1) /usr/sbin/dnsmasq --strict-order --bind-interfaces --pid-file=/var/run/libvirt/network/default.pid --conf-file= --except-interface lo --txt-record="txt-record","some value, which is something" --addn-hosts=/var/run/libvirt/network/default.hosts --l

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-30 Thread Michal Novotny
[snip] > Perhaps, you could implement (instead of tags for PTR, CNAME, etc.) > > > >host1 >host2 >host3 > > > > instead, which would write a file > >192.168.122.1 host1 host2 host3 > > and pass it to dnsmasq via --addn-hosts. But every feature should

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Paweł Krześniak
On Fri, Mar 25, 2011 at 22:02, Laine Stump wrote: > As a matter of fact, I think that not only is this useful, but configuring > other capabilities presented by dnsmasq would be good. I think you'll find a > kindred spirit in Paweł Krześniak, who was also wanting some other dnsmasq > capabilities

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Laine Stump
On 03/29/2011 06:52 AM, Michal Novotny wrote: [snip] So I guess we should disable the spaces in the name since it's being interpreted like \032 characters as can be seen in the dig output - we should either disable such a definition entirely or change spaces (' ') to dashes ('-'). But escaping t

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Michal Novotny
On 03/29/2011 05:12 PM, Paolo Bonzini wrote: > On 03/29/2011 05:08 PM, Michal Novotny wrote: >> Ok, however vendor-class and user-class should be used together and >> therefore it could be committed into one commit, right? The next commit >> could be the dhcp-mac one... right ? > No, they can be on

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Paolo Bonzini
On 03/29/2011 05:08 PM, Michal Novotny wrote: Ok, however vendor-class and user-class should be used together and therefore it could be committed into one commit, right? The next commit could be the dhcp-mac one... right ? No, they can be one patch series, but they should be separate commits.

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Michal Novotny
[snip] >> Great. Good to implement this then however I'm not sure about the >> parameter for DNSMasq. What should network-id tag mean and >> what should it match? > It can be a progressive number. You use it later to limit the "scope" > of --dhcp-boot options. > Oh, I see. It could make sense

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Paolo Bonzini
On 03/29/2011 01:37 PM, Michal Novotny wrote: On 03/29/2011 01:16 PM, Paolo Bonzini wrote: On 03/29/2011 12:52 PM, Michal Novotny wrote: [snip] It would be great to: 1) add and tags inside that allow filtering according to user/vendor classes Well, I didn't know this is supported by DN

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Michal Novotny
On 03/29/2011 01:16 PM, Paolo Bonzini wrote: > On 03/29/2011 12:52 PM, Michal Novotny wrote: >> [snip] >>> It would be great to: >>> >>> 1) add and tags inside that allow >>> filtering according to user/vendor classes >> Well, I didn't know this is supported by DNSMasq but it seems to be > Yes,

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Paolo Bonzini
On 03/29/2011 12:52 PM, Michal Novotny wrote: [snip] It would be great to: 1) add and tags inside that allow filtering according to user/vendor classes Well, I didn't know this is supported by DNSMasq but it seems to be Yes, I am using it. :) -4, --dhcp-mac=, Map

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Paolo Bonzini
On 03/29/2011 12:52 PM, Michal Novotny wrote: [snip] It would be great to: 1) add and tags inside that allow filtering according to user/vendor classes Well, I didn't know this is supported by DNSMasq but it seems to be Yes, I am using it. :) -4, --dhcp-mac=, Map

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-29 Thread Michal Novotny
[snip] > It would be great to: > > 1) add and tags inside that allow > filtering according to user/vendor classes Well, I didn't know this is supported by DNSMasq but it seems to be (according to the manpage at least): -U, --dhcp-vendorclass=, Map from a vendor-class strin

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-28 Thread Paolo Bonzini
On 03/28/2011 01:34 PM, Michal Novotny wrote: > Hi Laine, > thanks for your reply. Comments inline... > > On 03/25/2011 10:02 PM, Laine Stump wrote: >> I haven't had time yet to look at the code in detail, but thought I >> should send this preliminary commentary. >> >> On 03/24/2011 09:58 AM, Mich

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-28 Thread Michal Novotny
[snip] > Is this really necessary? We're not talking about a shell commandline > here, but an array of null terminated strings. If it's a restriction > placed by dnsmasq itself, then we should just disallow ' ' during > parsing rather than silently changing it, to avoid surprises. > > Well, I'v

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-28 Thread Michal Novotny
Hi Laine, thanks for your reply. Comments inline... On 03/25/2011 10:02 PM, Laine Stump wrote: > I haven't had time yet to look at the code in detail, but thought I > should send this preliminary commentary. > > On 03/24/2011 09:58 AM, Michal Novotny wrote: >> Hi, >> this is the patch to add DNS

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-25 Thread Laine Stump
I haven't had time yet to look at the code in detail, but thought I should send this preliminary commentary. On 03/24/2011 09:58 AM, Michal Novotny wrote: Hi, this is the patch to add DNS TXT record support to libvirt networking driver since this is feature that's supported by DNSMasq that's be

[libvirt] [PATCH] Add support for DNS TXT records

2011-03-24 Thread Michal Novotny
Hi, this is the patch to add DNS TXT record support to libvirt networking driver since this is feature that's supported by DNSMasq that's being used by the bridge driver. Maybe you fail to understand the reasons why to implement such a feature however it's a good thing IMHO since user could provid