Re: [libvirt] [PATCH] Add virsh commands for virInterface* functions - Take 2

2009-06-19 Thread Hugh O. Brock
On Fri, Jun 19, 2009 at 05:24:20PM +0200, Daniel Veillard wrote: > On Fri, Jun 19, 2009 at 10:57:59AM -0400, Laine Stump wrote: > > > > This is a resubmission of the virsh commands to expose virInterface* > > functionality. I've made the following changes from the original: > > > > 1) command nam

Re: [libvirt] [PATCH] Add virsh commands for virInterface* functions - Take 2

2009-06-19 Thread Daniel Veillard
On Fri, Jun 19, 2009 at 10:57:59AM -0400, Laine Stump wrote: > > This is a resubmission of the virsh commands to expose virInterface* > functionality. I've made the following changes from the original: > > 1) command names changed from if-* to iface-* > > 2) "if-create" is now "iface-start" > >

[libvirt] [PATCH] Add virsh commands for virInterface* functions - Take 2

2009-06-19 Thread Laine Stump
This is a resubmission of the virsh commands to expose virInterface* functionality. I've made the following changes from the original: 1) command names changed from if-* to iface-* 2) "if-create" is now "iface-start" 3) iface-edit implementation is manually included directly in virsh.c rathe

Re: [libvirt] [PATCH] Add virsh commands for virInterface* functions.

2009-06-16 Thread Daniel P. Berrange
On Mon, Jun 15, 2009 at 10:56:41PM -0400, Laine Stump wrote: > >>+vshPrintExtra(ctl, "%-20s %-30s\n", _("Name"), _("MAC Address")); > >>+vshPrintExtra(ctl, > >>"--\n"); > >>+ > >>+for (i = 0; i < ifCount; i++) { > >>+virInterfaceP

Re: [libvirt] [PATCH] Add virsh commands for virInterface* functions.

2009-06-15 Thread Laine Stump
On 06/15/2009 03:26 PM, Daniel P. Berrange wrote: On Fri, Jun 12, 2009 at 10:25:19AM -0400, Laine Stump wrote: I think this is complete (can't really try it out until the test driver is running), but have a few questions about it: 1) Does the command set look complete? 2) Do you agree with

Re: [libvirt] [PATCH] Add virsh commands for virInterface* functions.

2009-06-15 Thread Daniel P. Berrange
On Fri, Jun 12, 2009 at 10:25:19AM -0400, Laine Stump wrote: > > I think this is complete (can't really try it out until the test > driver is running), but have a few questions about it: > > 1) Does the command set look complete? > > 2) Do you agree with the naming (using "if-", and following th

[libvirt] [PATCH] Add virsh commands for virInterface* functions.

2009-06-12 Thread Laine Stump
I think this is complete (can't really try it out until the test driver is running), but have a few questions about it: 1) Does the command set look complete? 2) Do you agree with the naming (using "if-", and following the libvirt convention for if-create/if-destroy, rather than the fedora