Re: [libvirt] [PATCH] Adds the missing vol-pool command to virsh.

2010-06-08 Thread Justin Clift
On 06/08/2010 11:17 PM, Eric Blake wrote: On 06/08/2010 06:03 AM, Justin Clift wrote: Hi all, Much better - git am liked this patch. And a tip for your matching your commit message style to other commits: list a category first, use all lower-case, and end without a period. While not essentia

Re: [libvirt] [PATCH] Adds the missing vol-pool command to virsh.

2010-06-08 Thread Eric Blake
On 06/08/2010 06:03 AM, Justin Clift wrote: > Hi all, Much better - git am liked this patch. And a tip for your matching your commit message style to other commits: list a category first, use all lower-case, and end without a period. While not essential, doing these things will make 'git log --o

[libvirt] [PATCH] Adds the missing vol-pool command to virsh.

2010-06-08 Thread Justin Clift
Hi all, This patch adds a "vol-pool" command to virsh, to round out the conversion functions for vols in virsh. At the moment, if we start with a volume name and a pool id, we're all good. We can convert from that pair to either a volume key or volume path. But, if we're given just a volume k

Re: [libvirt] [PATCH] Adds the missing vol-pool command to virsh. Now when given only a volume key or path, the complete pool+volume_name can be determined easily.

2010-06-07 Thread Justin Clift
On 06/07/2010 09:07 PM, Justin Clift wrote: --- tools/virsh.c | 48 1 files changed, 48 insertions(+), 0 deletions(-) This patch adds a "vol-pool" command to virsh, to round out the conversion functions for vols in virsh. At the moment, if we s

[libvirt] [PATCH] Adds the missing vol-pool command to virsh. Now when given only a volume key or path, the complete pool+volume_name can be determined easily.

2010-06-07 Thread Justin Clift
--- tools/virsh.c | 48 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 1279f41..95aea0f 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -5975,6 +5975,53 @@ cmdVolName(vshControl *ctl, const v