Re: [libvirt] [PATCH] Avoid passing NULL to printf %s specifier

2009-01-19 Thread Daniel P. Berrange
On Thu, Jan 15, 2009 at 07:19:33AM -0800, john.le...@sun.com wrote: > # HG changeset patch > # User john.le...@sun.com > # Date 1232032750 28800 > # Node ID 0335828806b5b3855c8eeaee31446a7bd0c02974 > # Parent e542223a4c52d978d4507de709f50885920a5b44 > Avoid passing NULL to printf %s specifier > >

Re: [libvirt] [PATCH] Avoid passing NULL to printf %s specifier

2009-01-15 Thread Daniel Veillard
On Thu, Jan 15, 2009 at 07:19:33AM -0800, john.le...@sun.com wrote: > # HG changeset patch > # User john.le...@sun.com > # Date 1232032750 28800 > # Node ID 0335828806b5b3855c8eeaee31446a7bd0c02974 > # Parent e542223a4c52d978d4507de709f50885920a5b44 > Avoid passing NULL to printf %s specifier A

Re: [libvirt] [PATCH] Avoid passing NULL to printf %s specifier

2009-01-15 Thread Richard W.M. Jones
On Thu, Jan 15, 2009 at 07:19:33AM -0800, john.le...@sun.com wrote: > # HG changeset patch > # User john.le...@sun.com > # Date 1232032750 28800 > # Node ID 0335828806b5b3855c8eeaee31446a7bd0c02974 > # Parent e542223a4c52d978d4507de709f50885920a5b44 > Avoid passing NULL to printf %s specifier +1

[libvirt] [PATCH] Avoid passing NULL to printf %s specifier

2009-01-15 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1232032750 28800 # Node ID 0335828806b5b3855c8eeaee31446a7bd0c02974 # Parent e542223a4c52d978d4507de709f50885920a5b44 Avoid passing NULL to printf %s specifier This is non-portable. Signed-off-by: John Levon diff --git a/src/internal.h b/sr

Re: [libvirt] [PATCH] Avoid passing NULL to printf %s specifier

2009-01-15 Thread John Levon
On Thu, Jan 15, 2009 at 12:17:21PM +0100, Jim Meyering wrote: > #define NULLSTR(s) \ > ((void)verify_true(sizeof *(s) == sizeof (char)), \ >(s) ? (s) : "(null)") Sure, I can try something like this. regards john -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mai

Re: [libvirt] [PATCH] Avoid passing NULL to printf %s specifier

2009-01-15 Thread Jim Meyering
john.le...@sun.com wrote: > Avoid passing NULL to printf %s specifier This looks fine. Thanks! > diff --git a/src/internal.h b/src/internal.h > --- a/src/internal.h > +++ b/src/internal.h > @@ -115,6 +115,8 @@ > #define ATTRIBUTE_RETURN_CHECK > #endif /* __GNUC__ *

Re: [libvirt] [PATCH] Avoid passing NULL to printf %s specifier

2009-01-15 Thread Daniel P. Berrange
On Wed, Jan 14, 2009 at 06:03:59PM -0800, john.le...@sun.com wrote: > # HG changeset patch > # User john.le...@sun.com > # Date 1231985011 28800 > # Node ID 2766ee91dd5ea8e99dac27ce730af0dc46a1d107 > # Parent 082e0f7d5de236e69bea177c8d4c4204350144c1 > Avoid passing NULL to printf %s specifier > >

[libvirt] [PATCH] Avoid passing NULL to printf %s specifier

2009-01-14 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1231985011 28800 # Node ID 2766ee91dd5ea8e99dac27ce730af0dc46a1d107 # Parent 082e0f7d5de236e69bea177c8d4c4204350144c1 Avoid passing NULL to printf %s specifier This is non-portable. Signed-off-by: John Levon diff --git a/src/internal.h b/sr