Re: [libvirt] [PATCH] Better error reporting for failed migration.

2010-02-19 Thread Daniel Veillard
On Thu, Feb 18, 2010 at 10:38:37AM -0500, Chris Lalancette wrote: > If the hostname as returned by "gethostname" resolves > to "localhost" (as it does with the broken Fedora-12 > installer), then live migration will fail because the > source will try to migrate to itself. Detect this > situation u

[libvirt] [PATCH] Better error reporting for failed migration.

2010-02-18 Thread Chris Lalancette
If the hostname as returned by "gethostname" resolves to "localhost" (as it does with the broken Fedora-12 installer), then live migration will fail because the source will try to migrate to itself. Detect this situation up-front and abort the live migration before we do any real work. Signed-off

Re: [libvirt] [PATCH] Better error reporting for failed migration.

2009-10-19 Thread Chris Lalancette
Daniel P. Berrange wrote: >> +if (STREQ(hostname, "localhost")) { >> +VIR_FREE(hostname); >> +qemudReportError(dconn, NULL, NULL, VIR_ERR_INVALID_ARG, "%s", >> + _("Could not resolve destination hostname; " >> +

Re: [libvirt] [PATCH] Better error reporting for failed migration.

2009-10-16 Thread Daniel P. Berrange
On Thu, Oct 15, 2009 at 11:26:38AM +0200, Chris Lalancette wrote: > The comment in the code says most of it, but when the destination > hostname resolution is screwed up, print a proper error instead > of the very unhelpful "unknown error". > > Note that I'm not overly fond of the wording in the e

[libvirt] [PATCH] Better error reporting for failed migration.

2009-10-15 Thread Chris Lalancette
The comment in the code says most of it, but when the destination hostname resolution is screwed up, print a proper error instead of the very unhelpful "unknown error". Note that I'm not overly fond of the wording in the error message, so I'm open to suggestions. Signed-off-by: Chris Lalancette