Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-15 Thread Daniel P. Berrange
On Thu, May 15, 2008 at 02:59:52PM +0200, Stefan de Konink wrote: > On Wed, 14 May 2008, Daniel P. Berrange wrote: > > > On Sat, May 10, 2008 at 06:43:11PM +0200, Stefan de Konink wrote: > > > On Sat, 10 May 2008, Daniel P. Berrange wrote: > > > > > > > The code all looks good to me, but can you a

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-15 Thread Stefan de Konink
On Wed, 14 May 2008, Daniel P. Berrange wrote: > On Sat, May 10, 2008 at 06:43:11PM +0200, Stefan de Konink wrote: > > On Sat, 10 May 2008, Daniel P. Berrange wrote: > > > > > The code all looks good to me, but can you also provide an update for > > > the default configuration file in qemud/libvir

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-14 Thread Daniel P. Berrange
On Sat, May 10, 2008 at 06:43:11PM +0200, Stefan de Konink wrote: > On Sat, 10 May 2008, Daniel P. Berrange wrote: > > > The code all looks good to me, but can you also provide an update for > > the default configuration file in qemud/libvirtd.conf with a (commented > > out) example setting. > >

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-13 Thread Stefan de Konink
Stefan de Konink schreef: On Tue, 13 May 2008, Stefan de Konink wrote: On Sat, May 10, 2008 at 07:42:51PM +0200, Stefan de Konink wrote: About mdns, do you think it would be a good thing to *not* follow the Avahi advise and explicitly set the host the service is running on? In my humble opinio

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-13 Thread Stefan de Konink
On Tue, 13 May 2008, Stefan de Konink wrote: > > On Sat, May 10, 2008 at 07:42:51PM +0200, Stefan de Konink wrote: > > > About mdns, do you think it would be a good thing to *not* follow the > > > Avahi advise and explicitly set the host the service is running on? In my > > > humble opinion I thin

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-12 Thread Stefan de Konink
Daniel P. Berrange schreef: There is indentation whitespace damage here. Please check the HACKING file for details of how to setup *vim* and emacs to comply with libvirt indentation rules automatically. What is the vim suggestion made there? I see emacs en GNU indent. Stefan -- Libvir-list m

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-12 Thread Stefan de Konink
On Tue, 13 May 2008, Daniel P. Berrange wrote: > On Sat, May 10, 2008 at 07:42:51PM +0200, Stefan de Konink wrote: > > About mdns, do you think it would be a good thing to *not* follow the > > Avahi advise and explicitly set the host the service is running on? In my > > humble opinion I think that

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-12 Thread Daniel P. Berrange
On Sat, May 10, 2008 at 07:42:51PM +0200, Stefan de Konink wrote: > About mdns, do you think it would be a good thing to *not* follow the > Avahi advise and explicitly set the host the service is running on? In my > humble opinion I think that would be a wise decision. > > host The host this serv

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-10 Thread Stefan de Konink
About mdns, do you think it would be a good thing to *not* follow the Avahi advise and explicitly set the host the service is running on? In my humble opinion I think that would be a wise decision. hostThe host this services is residing on. We recommend to pass NULL here, the daemon will than

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-10 Thread Stefan de Konink
On Sat, 10 May 2008, Daniel P. Berrange wrote: > The code all looks good to me, but can you also provide an update for > the default configuration file in qemud/libvirtd.conf with a (commented > out) example setting. Oops :) That didn't make it in the patch. But was already written. (Please fix m

Re: [libvirt] [PATCH] Bind to ip_addr support.

2008-05-10 Thread Daniel P. Berrange
On Sat, May 10, 2008 at 05:31:53PM +0200, Stefan de Konink wrote: > Hi, > > > Mainly because I think Daniel always gives good feedback and comments, > plus I don't want to be a troll on this list, I decided the time had come > to spend some minutes to hack up a patch :) > > It has been tested: >

[libvirt] [PATCH] Bind to ip_addr support.

2008-05-10 Thread Stefan de Konink
Hi, Mainly because I think Daniel always gives good feedback and comments, plus I don't want to be a troll on this list, I decided the time had come to spend some minutes to hack up a patch :) It has been tested: tcp0 0 192.168.0.5:16509 *:* LISTEN vs tc