Re: [libvirt] [PATCH] Enable support for nested SVM (v4)

2010-10-13 Thread Daniel Veillard
On Wed, Oct 13, 2010 at 04:04:00PM +0100, Daniel P. Berrange wrote: > This enables support for nested SVM using the regular CPU > model/features block. If the CPU model or features include > 'svm', then the '-enable-nesting' flag will be added to the > QEMU command line. Latest out of tree patches

Re: [libvirt] [PATCH] Enable support for nested SVM (v4)

2010-10-13 Thread Eric Blake
On 10/13/2010 09:04 AM, Daniel P. Berrange wrote: This enables support for nested SVM using the regular CPU model/features block. If the CPU model or features include 'svm', then the '-enable-nesting' flag will be added to the QEMU command line. Latest out of tree patches for nested 'vmx', no lon

[libvirt] [PATCH] Enable support for nested SVM (v4)

2010-10-13 Thread Daniel P. Berrange
This enables support for nested SVM using the regular CPU model/features block. If the CPU model or features include 'svm', then the '-enable-nesting' flag will be added to the QEMU command line. Latest out of tree patches for nested 'vmx', no longer require the '-enable-nesting' flag. They instead

Re: [libvirt] [PATCH] Enable support for nested SVM

2010-10-13 Thread Daniel Veillard
On Tue, Oct 12, 2010 at 08:23:21AM -0600, Eric Blake wrote: > On 10/12/2010 04:46 AM, Daniel P. Berrange wrote: > >This enables support for nested SVM using the regular CPU > >model/features block. If the CPU model or features include > >'svm', then the '-enable-nesting' flag will be added to the >

Re: [libvirt] [PATCH] Enable support for nested SVM

2010-10-12 Thread Eric Blake
On 10/12/2010 04:46 AM, Daniel P. Berrange wrote: This enables support for nested SVM using the regular CPU model/features block. If the CPU model or features include 'svm', then the '-enable-nesting' flag will be added to the QEMU command line. Latest out of tree patches for nested 'vmx', no lon

[libvirt] [PATCH] Enable support for nested SVM

2010-10-12 Thread Daniel P. Berrange
This enables support for nested SVM using the regular CPU model/features block. If the CPU model or features include 'svm', then the '-enable-nesting' flag will be added to the QEMU command line. Latest out of tree patches for nested 'vmx', no longer require the '-enable-nesting' flag. They instead

Re: [libvirt] [PATCH] Enable support for nested SVM

2010-09-23 Thread Jiri Denemark
> diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c > index def6974..c7a282e 100644 > --- a/src/cpu/cpu.c > +++ b/src/cpu/cpu.c > @@ -424,3 +424,27 @@ cpuUpdate(virCPUDefPtr guest, > > return driver->update(guest, host); > } > + > +bool > +cpuHasFeature(const char *arch, > + const uni

Re: [libvirt] [PATCH] Enable support for nested SVM

2010-09-22 Thread Daniel P. Berrange
On Wed, Sep 22, 2010 at 11:13:06AM -0600, Eric Blake wrote: > On 09/22/2010 10:47 AM, Daniel P. Berrange wrote: > > Marking patches as v2 makes it easier for reviewers to note that this is > fixing comments from an earlier review :) > > >This enables support for nested SVM using the regular CPU

Re: [libvirt] [PATCH] Enable support for nested SVM

2010-09-22 Thread Daniel P. Berrange
On Wed, Sep 22, 2010 at 02:19:06PM -0400, Dave Allan wrote: > On Wed, Sep 22, 2010 at 05:47:42PM +0100, Daniel P. Berrange wrote: > > This enables support for nested SVM using the regular CPU > > model/features block. If the CPU model or features include > > 'svm' or 'vmx', then the '-enable-nestin

Re: [libvirt] [PATCH] Enable support for nested SVM

2010-09-22 Thread Dave Allan
On Wed, Sep 22, 2010 at 05:47:42PM +0100, Daniel P. Berrange wrote: > This enables support for nested SVM using the regular CPU > model/features block. If the CPU model or features include > 'svm' or 'vmx', then the '-enable-nesting' flag will be > added to the QEMU command line. Several of the mod

Re: [libvirt] [PATCH] Enable support for nested SVM

2010-09-22 Thread Eric Blake
On 09/22/2010 10:47 AM, Daniel P. Berrange wrote: Marking patches as v2 makes it easier for reviewers to note that this is fixing comments from an earlier review :) This enables support for nested SVM using the regular CPU model/features block. If the CPU model or features include 'svm' or 'v

[libvirt] [PATCH] Enable support for nested SVM

2010-09-22 Thread Daniel P. Berrange
This enables support for nested SVM using the regular CPU model/features block. If the CPU model or features include 'svm' or 'vmx', then the '-enable-nesting' flag will be added to the QEMU command line. Several of the models already include svm support, but QEMU was just masking out the svm bit s

Re: [libvirt] [PATCH] Enable support for nested SVM

2010-09-22 Thread Jiri Denemark
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c > index 7a37c70..a2aab95 100644 > --- a/src/qemu/qemu_conf.c > +++ b/src/qemu/qemu_conf.c > @@ -3494,13 +3496,36 @@ error: > } > > > +#define CPUID_FUNCTION_SVM 0x8001 > +#define CPUID_ECX_SVM 0x0004 > + > +#define CPUID_F

[libvirt] [PATCH] Enable support for nested SVM

2010-09-22 Thread Daniel P. Berrange
This enables support for nested SVM using the regular CPU model/features block. If the CPU model or features include 'svm' or 'vmx', then the '-enable-nesting' flag will be added to the QEMU command line. Several of the models already include svm support, but QEMU was just masking out the svm bit s