Re: [libvirt] [PATCH] Fix build with GCC 8 new warnings

2018-02-13 Thread Andrea Bolognani
On Tue, 2018-02-13 at 12:21 +, Daniel P. Berrangé wrote: > @@ -175,9 +175,9 @@ qemuDomainAsyncJobPhaseToString(qemuDomainAsyncJob job, > case QEMU_ASYNC_JOB_NONE: > case QEMU_ASYNC_JOB_LAST: > ATTRIBUTE_FALLTHROUGH; > +default: > +return "none"; > } > - > -

Re: [libvirt] [PATCH] Fix build with GCC 8 new warnings

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 01:58:44PM +0100, Jiri Denemark wrote: > On Tue, Feb 13, 2018 at 12:21:11 +, Daniel P. Berrangé wrote: > > GCC 8 added a -Wcast-function-type warning to -Wextra by > > default. This complains if you try to explicitly cast > > one function signature to another function si

Re: [libvirt] [PATCH] Fix build with GCC 8 new warnings

2018-02-13 Thread Jiri Denemark
On Tue, Feb 13, 2018 at 12:21:11 +, Daniel P. Berrangé wrote: > GCC 8 added a -Wcast-function-type warning to -Wextra by > default. This complains if you try to explicitly cast > one function signature to another function signature > with incompatible args. This is something we do many > times

[libvirt] [PATCH] Fix build with GCC 8 new warnings

2018-02-13 Thread Daniel P . Berrangé
GCC 8 added a -Wcast-function-type warning to -Wextra by default. This complains if you try to explicitly cast one function signature to another function signature with incompatible args. This is something we do many times in libvirt especially with event callbacks. The hack to silence the warning