Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-03-04 Thread Daniel P. Berrange
On Sat, Mar 02, 2013 at 11:42:01AM -0600, Doug Goldstein wrote: > On Fri, Mar 1, 2013 at 8:44 AM, Eric Blake wrote: > > On 03/01/2013 03:18 AM, Daniel P. Berrange wrote: > >>> > >>> So the conclusion is that I see no extra harm in calling nl_geterror(). > >>> ACK. > >> > >> Except the API signatu

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-03-03 Thread Laine Stump
On 03/02/2013 12:35 PM, Doug Goldstein wrote: > > But long term you guys will likely want to push Fedora and > RHEL7 to libnl3 libvirt uses libnl3 on any distro that has it available, including Fedora 18+, so that's already covered. -- libvir-list mailing list libvir-list@redhat.com https://www.r

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-03-02 Thread Doug Goldstein
On Fri, Mar 1, 2013 at 8:44 AM, Eric Blake wrote: > On 03/01/2013 03:18 AM, Daniel P. Berrange wrote: >>> >>> So the conclusion is that I see no extra harm in calling nl_geterror(). ACK. >> >> Except the API signature is different, so my patch won't work with >> both versions :-( > > Sounds like i

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-03-02 Thread Doug Goldstein
On Thu, Feb 28, 2013 at 1:11 PM, Laine Stump wrote: > On 02/28/2013 11:37 AM, Daniel P. Berrange wrote: >> On Fri, Mar 01, 2013 at 12:31:34AM +0800, Daniel Veillard wrote: >>> On Thu, Feb 28, 2013 at 04:24:17PM +, Daniel P. Berrange wrote: On Thu, Feb 28, 2013 at 04:16:37PM +, Daniel

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-03-01 Thread Eric Blake
On 03/01/2013 03:18 AM, Daniel P. Berrange wrote: >> >> So the conclusion is that I see no extra harm in calling nl_geterror(). ACK. > > Except the API signature is different, so my patch won't work with > both versions :-( Sounds like its time for a wrapper function that #ifdefs away the differe

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-03-01 Thread Daniel P. Berrange
On Thu, Feb 28, 2013 at 11:59:42AM -0500, Laine Stump wrote: > On 02/28/2013 11:16 AM, Daniel P. Berrange wrote: > > On Thu, Feb 28, 2013 at 11:11:53AM -0500, Laine Stump wrote: > >> On 02/28/2013 08:37 AM, Daniel P. Berrange wrote: > >>> From: "Daniel P. Berrange" > >>> > >>> The nl_recvmsg does

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-02-28 Thread Laine Stump
On 02/28/2013 11:37 AM, Daniel P. Berrange wrote: > On Fri, Mar 01, 2013 at 12:31:34AM +0800, Daniel Veillard wrote: >> On Thu, Feb 28, 2013 at 04:24:17PM +, Daniel P. Berrange wrote: >>> On Thu, Feb 28, 2013 at 04:16:37PM +, Daniel P. Berrange wrote: >> [...] >>> Oh joy, it is worse than y

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-02-28 Thread Daniel P. Berrange
On Fri, Mar 01, 2013 at 12:31:34AM +0800, Daniel Veillard wrote: > On Thu, Feb 28, 2013 at 04:24:17PM +, Daniel P. Berrange wrote: > > On Thu, Feb 28, 2013 at 04:16:37PM +, Daniel P. Berrange wrote: > [...] > > Oh joy, it is worse than you could possibly imagine. > > > > On libnl1 the retu

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-02-28 Thread Laine Stump
On 02/28/2013 11:16 AM, Daniel P. Berrange wrote: > On Thu, Feb 28, 2013 at 11:11:53AM -0500, Laine Stump wrote: >> On 02/28/2013 08:37 AM, Daniel P. Berrange wrote: >>> From: "Daniel P. Berrange" >>> >>> The nl_recvmsg does not always set errno. Instead it returns >>> its own custom set of error

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-02-28 Thread Daniel Veillard
On Thu, Feb 28, 2013 at 04:24:17PM +, Daniel P. Berrange wrote: > On Thu, Feb 28, 2013 at 04:16:37PM +, Daniel P. Berrange wrote: [...] > Oh joy, it is worse than you could possibly imagine. > > On libnl1 the return value is a valid -errno, while in libnl3 > the return value is an error co

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-02-28 Thread Daniel P. Berrange
On Thu, Feb 28, 2013 at 04:16:37PM +, Daniel P. Berrange wrote: > On Thu, Feb 28, 2013 at 11:11:53AM -0500, Laine Stump wrote: > > On 02/28/2013 08:37 AM, Daniel P. Berrange wrote: > > > From: "Daniel P. Berrange" > > > > > > The nl_recvmsg does not always set errno. Instead it returns > > > i

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-02-28 Thread Daniel P. Berrange
On Thu, Feb 28, 2013 at 11:11:53AM -0500, Laine Stump wrote: > On 02/28/2013 08:37 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > The nl_recvmsg does not always set errno. Instead it returns > > its own custom set of error codes. Thus we were reporting the > > wrong data. > >

Re: [libvirt] [PATCH] Fix error report from nl_recvmsg

2013-02-28 Thread Laine Stump
On 02/28/2013 08:37 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The nl_recvmsg does not always set errno. Instead it returns > its own custom set of error codes. Thus we were reporting the > wrong data. > --- > src/util/virnetlink.c | 5 +++-- > 1 file changed, 3 insertions(+),

[libvirt] [PATCH] Fix error report from nl_recvmsg

2013-02-28 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The nl_recvmsg does not always set errno. Instead it returns its own custom set of error codes. Thus we were reporting the wrong data. --- src/util/virnetlink.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util/virnetlink.c b/src/util/vi