Re: [libvirt] [PATCH] Fix logic for assigning PCI addresses to USB2 companion controllers

2012-05-15 Thread Daniel P. Berrange
On Mon, May 14, 2012 at 03:55:50PM -0600, Eric Blake wrote: > On 05/14/2012 04:19 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Currently each USB2 companion controller gets put on a separate > > PCI slot. Not only is this wasteful of PCI slots, but it is not > > in complia

Re: [libvirt] [PATCH] Fix logic for assigning PCI addresses to USB2 companion controllers

2012-05-14 Thread Eric Blake
On 05/14/2012 04:19 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Currently each USB2 companion controller gets put on a separate > PCI slot. Not only is this wasteful of PCI slots, but it is not > in compliance with the spec for USB2 controllers. The master > echi1 and all compa

Re: [libvirt] [PATCH] Fix logic for assigning PCI addresses to USB2 companion controllers

2012-05-14 Thread Daniel P. Berrange
On Mon, May 14, 2012 at 01:06:50PM +0200, Hans de Goede wrote: > Hi, > > Thanks for working on this. I've little useful feedback atm > I'm afraid, but I do have a question based on reading the xml > for the tests, is it necessary to set the startports explicitly? > or do they get the correct defau

Re: [libvirt] [PATCH] Fix logic for assigning PCI addresses to USB2 companion controllers

2012-05-14 Thread Hans de Goede
Hi, Thanks for working on this. I've little useful feedback atm I'm afraid, but I do have a question based on reading the xml for the tests, is it necessary to set the startports explicitly? or do they get the correct default based on the model, ie uhci1 startport 0, uhci startport 2, etc? Regar

[libvirt] [PATCH] Fix logic for assigning PCI addresses to USB2 companion controllers

2012-05-14 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently each USB2 companion controller gets put on a separate PCI slot. Not only is this wasteful of PCI slots, but it is not in compliance with the spec for USB2 controllers. The master echi1 and all companion controllers should be in the same slot, with echi1 in fun