Re: [libvirt] [PATCH] Fix misc bugs in virCommandPtr

2011-03-15 Thread Daniel P. Berrange
On Tue, Mar 15, 2011 at 08:03:09AM -0600, Eric Blake wrote: > On 03/15/2011 06:32 AM, Daniel P. Berrange wrote: > > The virCommandNewArgs() method would free the virCommandPtr > > if it failed to add the args. This meant errors reported in > > virCommandAddArgSet() were lost. Simply removing the ch

Re: [libvirt] [PATCH] Fix misc bugs in virCommandPtr

2011-03-15 Thread Eric Blake
On 03/15/2011 06:32 AM, Daniel P. Berrange wrote: > The virCommandNewArgs() method would free the virCommandPtr > if it failed to add the args. This meant errors reported in > virCommandAddArgSet() were lost. Simply removing the check > for errors from the constructor means they can be reported > c

Re: [libvirt] [PATCH] Fix misc bugs in virCommandPtr

2011-03-15 Thread Laine Stump
On 03/15/2011 08:32 AM, Daniel P. Berrange wrote: The virCommandNewArgs() method would free the virCommandPtr if it failed to add the args. This meant errors reported in virCommandAddArgSet() were lost. Simply removing the check for errors from the constructor means they can be reported correctly

[libvirt] [PATCH] Fix misc bugs in virCommandPtr

2011-03-15 Thread Daniel P. Berrange
The virCommandNewArgs() method would free the virCommandPtr if it failed to add the args. This meant errors reported in virCommandAddArgSet() were lost. Simply removing the check for errors from the constructor means they can be reported correctly later The virCommandAddEnvPassCommon() method fail