On Thu, Jun 02, 2011 at 10:04:44AM +0100, Neil Wilson wrote:
> On Wed, 2011-06-01 at 13:38 -0600, Eric Blake wrote:
>
> > Meanwhile, as to your question about the libvirt testsuit including RHEL
> > qemu -help output: that merely proves that libvirt is properly parsing
> > the available -help outp
On Wed, 2011-06-01 at 13:38 -0600, Eric Blake wrote:
> Meanwhile, as to your question about the libvirt testsuit including RHEL
> qemu -help output: that merely proves that libvirt is properly parsing
> the available -help output, and not that libvirt is inferring any
> special properties of RHEL
On 05/24/2011 03:42 AM, Neil Wilson wrote:
> On Tue, 2011-05-24 at 10:37 +0100, Daniel P. Berrange wrote:
>
>> Use the libvirt that ships with RHEL6, or apply the RHEL6 specific
>> patches manually when building an alternative libvirt for RHEL6.
>> It isn't sustainable for upstream projects to dea
On Tue, 2011-05-24 at 10:37 +0100, Daniel P. Berrange wrote:
> Use the libvirt that ships with RHEL6, or apply the RHEL6 specific
> patches manually when building an alternative libvirt for RHEL6.
> It isn't sustainable for upstream projects to deal with hacks for
> every crazy non-upstream change
On Tue, May 24, 2011 at 10:31:19AM +0100, Neil Wilson wrote:
> On Tue, 2011-05-24 at 10:10 +0100, Daniel P. Berrange wrote:
>
> > IMHO RHEL specific hacks don't belong in upstream libvirt code.
>
> Currently there are checks against the qemu-kvm RHEL6 help files in the
> test system of libvirt, a
On Tue, 2011-05-24 at 10:10 +0100, Daniel P. Berrange wrote:
> IMHO RHEL specific hacks don't belong in upstream libvirt code.
Currently there are checks against the qemu-kvm RHEL6 help files in the
test system of libvirt, and it is incorrect - as RHEL6 qemu uses netdev,
not add_host.
So why are
On Tue, May 24, 2011 at 07:16:28AM +0100, Neil Wilson wrote:
> This allows the attach-device derived functions to work on the vanilla
> RHEL6 versions of qemu. Looking for the '-spice' parameter differentiates
> the RHEL from non-RHEL versions.
>
> Signed-off-by: Neil Wilson
> ---
> src/qemu/qem
This allows the attach-device derived functions to work on the vanilla
RHEL6 versions of qemu. Looking for the '-spice' parameter differentiates
the RHEL from non-RHEL versions.
Signed-off-by: Neil Wilson
---
src/qemu/qemu_capabilities.c |7 ---
tests/qemuhelptest.c |2 ++
2
