Re: [libvirt] [PATCH] Fix possible segfault if starting qemu vm with an inactive virtual network

2008-10-06 Thread Cole Robinson
Daniel Veillard wrote: > On Thu, Oct 02, 2008 at 05:16:43PM -0400, Cole Robinson wrote: >> The attached patch fixes a possible segfault if trying >> to start a domain which tries to use an inactive >> virtual network. We should explicitly catch that error >> and report it, but that's a separate pat

Re: [libvirt] [PATCH] Fix possible segfault if starting qemu vm with an inactive virtual network

2008-10-03 Thread Daniel Veillard
On Thu, Oct 02, 2008 at 05:16:43PM -0400, Cole Robinson wrote: > The attached patch fixes a possible segfault if trying > to start a domain which tries to use an inactive > virtual network. We should explicitly catch that error > and report it, but that's a separate patch. Fix looks fine to me,

Re: [libvirt] [PATCH] Fix possible segfault if starting qemu vm with an inactive virtual network

2008-10-03 Thread Daniel P. Berrange
On Thu, Oct 02, 2008 at 05:16:43PM -0400, Cole Robinson wrote: > The attached patch fixes a possible segfault if trying > to start a domain which tries to use an inactive > virtual network. We should explicitly catch that error > and report it, but that's a separate patch. ACK Daniel -- |: Red H

[libvirt] [PATCH] Fix possible segfault if starting qemu vm with an inactive virtual network

2008-10-02 Thread Cole Robinson
The attached patch fixes a possible segfault if trying to start a domain which tries to use an inactive virtual network. We should explicitly catch that error and report it, but that's a separate patch. Thanks, Cole commit eca87f821890c7d54f2ba57288acad1b234ec13e Author: Cole Robinson <[EMAIL PROT