Re: [libvirt] [PATCH] Fix virConnectOpen.*() name requirements

2013-03-26 Thread Martin Kletzander
On 03/26/2013 03:23 PM, Guannan Ren wrote: > On 03/26/2013 10:18 PM, Martin Kletzander wrote: >> On 03/25/2013 05:08 PM, Martin Kletzander wrote: >>> On 03/25/2013 04:54 PM, Martin Kletzander wrote: virConnectOpenAuth didn't require 'name' to be specified (VIR_DEBUG used NULLSTR() for the

Re: [libvirt] [PATCH] Fix virConnectOpen.*() name requirements

2013-03-26 Thread Guannan Ren
On 03/26/2013 10:18 PM, Martin Kletzander wrote: On 03/25/2013 05:08 PM, Martin Kletzander wrote: On 03/25/2013 04:54 PM, Martin Kletzander wrote: virConnectOpenAuth didn't require 'name' to be specified (VIR_DEBUG used NULLSTR() for the output) and by default, if name == NULL, the default conn

Re: [libvirt] [PATCH] Fix virConnectOpen.*() name requirements

2013-03-26 Thread Martin Kletzander
On 03/25/2013 05:08 PM, Martin Kletzander wrote: > On 03/25/2013 04:54 PM, Martin Kletzander wrote: >> virConnectOpenAuth didn't require 'name' to be specified (VIR_DEBUG >> used NULLSTR() for the output) and by default, if name == NULL, the >> default connection uri is used. This was not indicate

Re: [libvirt] [PATCH] Fix virConnectOpen.*() name requirements

2013-03-25 Thread Martin Kletzander
On 03/25/2013 04:54 PM, Martin Kletzander wrote: > virConnectOpenAuth didn't require 'name' to be specified (VIR_DEBUG > used NULLSTR() for the output) and by default, if name == NULL, the > default connection uri is used. This was not indicated in the > documentation and wasn't checked for in oth

[libvirt] [PATCH] Fix virConnectOpen.*() name requirements

2013-03-25 Thread Martin Kletzander
virConnectOpenAuth didn't require 'name' to be specified (VIR_DEBUG used NULLSTR() for the output) and by default, if name == NULL, the default connection uri is used. This was not indicated in the documentation and wasn't checked for in other API's VIR_DEBUG outputs. --- Thanks to Guannan's patch