Re: [libvirt] [PATCH] Generate HACKING from docs/hacking.html.in

2010-11-12 Thread Eric Blake
On 11/12/2010 10:59 AM, Eric Blake wrote: >> >> +syntax-check: $(top_srcdir)/HACKING > > Move this line into cfg.mk. Since 'make syntax-check' can only > activated if you use GNU make (because it is only specified in > maint.mk), we should hide any dependencies added to it inside our > customiz

Re: [libvirt] [PATCH] Generate HACKING from docs/hacking.html.in

2010-11-12 Thread Matthias Bolte
2010/11/12 Eric Blake : > On 11/12/2010 10:15 AM, Matthias Bolte wrote: >> 2010/11/11 Eric Blake : >>> On 11/11/2010 01:39 PM, Matthias Bolte wrote: Tweak pre tags in docs/hacking.html.in to achieve proper indentation of their plaintext representation. Also use more b/i/code tag

Re: [libvirt] [PATCH] Generate HACKING from docs/hacking.html.in

2010-11-12 Thread Eric Blake
On 11/12/2010 10:15 AM, Matthias Bolte wrote: > 2010/11/11 Eric Blake : >> On 11/11/2010 01:39 PM, Matthias Bolte wrote: >>> Tweak pre tags in docs/hacking.html.in to achieve proper >>> indentation of their plaintext representation. >>> >>> Also use more b/i/code tags in docs/hacking.html.in. >>> -

Re: [libvirt] [PATCH] Generate HACKING from docs/hacking.html.in

2010-11-12 Thread Eric Blake
On 11/12/2010 10:15 AM, Matthias Bolte wrote: >>> HACKING | 602 >>> +- >> >> A lot of this diff is whitespace; the rest looks like it is pulling in >> missed bits. Overall, it looks pretty decent; and it's certainly more >> maintainab

Re: [libvirt] [PATCH] Generate HACKING from docs/hacking.html.in

2010-11-11 Thread Eric Blake
On 11/11/2010 01:39 PM, Matthias Bolte wrote: > Tweak pre tags in docs/hacking.html.in to achieve proper > indentation of their plaintext representation. > > Also use more b/i/code tags in docs/hacking.html.in. > --- > HACKING | 602 > +--