On Mon, Sep 08, 2008 at 09:33:40AM -0400, Cole Robinson wrote:
> Daniel Veillard wrote:
> >> +devname = basename(devpath);
> >> +srcname = basename(pool->def->source.devices[0].path);
> >
> > This seems to leak the two strings and not check for errors. That
> > would need to be fixed bef
Daniel Veillard wrote:
> On Fri, Sep 05, 2008 at 11:17:27PM -0400, Cole Robinson wrote:
>> static int
>> virStorageBackendDiskDeleteVol(virConnectPtr conn,
>> - virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
>> - virStorageVolDefPtr vol ATT
On Fri, Sep 05, 2008 at 11:17:27PM -0400, Cole Robinson wrote:
> static int
> virStorageBackendDiskDeleteVol(virConnectPtr conn,
> - virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
> - virStorageVolDefPtr vol ATTRIBUTE_UNUSED,
> +
Daniel P. Berrange wrote:
> On Tue, Aug 12, 2008 at 11:58:07PM -0400, Cole Robinson wrote:
>
>> Daniel P. Berrange wrote:
>>
>>> This isn't correct because the target path is not guarenteed to point to
>>> the master device name /dev/sda1. The user could have configured it to
>>> use a sta
On Tue, Aug 12, 2008 at 11:58:07PM -0400, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> >
> > This isn't correct because the target path is not guarenteed to point to
> > the master device name /dev/sda1. The user could have configured it to
> > use a stable path such as
> > /dev/disk/by-uui
Daniel P. Berrange wrote:
> On Mon, Aug 11, 2008 at 03:58:41PM -0400, Cole Robinson wrote:
>
>> The patch below implements virStorageVolDelete for volumes
>> on a disk pool.
>>
>> The only interesting thing here is that parted wants a
>> partition number to delete, so we need to peel off the
>>
On Mon, Aug 11, 2008 at 03:58:41PM -0400, Cole Robinson wrote:
> The patch below implements virStorageVolDelete for volumes
> on a disk pool.
>
> The only interesting thing here is that parted wants a
> partition number to delete, so we need to peel off the
> end of the volume's target path which
On Mon, Aug 11, 2008 at 03:58:41PM -0400, Cole Robinson wrote:
> The patch below implements virStorageVolDelete for volumes
> on a disk pool.
>
> The only interesting thing here is that parted wants a
> partition number to delete, so we need to peel off the
> end of the volume's target path which
The patch below implements virStorageVolDelete for volumes
on a disk pool.
The only interesting thing here is that parted wants a
partition number to delete, so we need to peel off the
end of the volume's target path which will be of the form
'/dev/sda1' or similar (I assume. If not, it's still
be
