Re: [libvirt] [PATCH] LXC fix rc handling in lxcVmStart

2009-10-13 Thread Daniel Veillard
On Tue, Oct 13, 2009 at 10:57:13AM +0900, Ryota Ozaki wrote: > Hi, > > In lxcVmStart we have to set rc = -1 before jumping to the cleanup > code when a local procedure call fails and the rc is overwritten, > however, some codes don't observe the rule and so invalid cleanups > are likely to happen.

Re: [libvirt] [PATCH] LXC fix rc handling in lxcVmStart

2009-10-13 Thread Daniel P. Berrange
On Tue, Oct 13, 2009 at 10:57:13AM +0900, Ryota Ozaki wrote: > Hi, > > In lxcVmStart we have to set rc = -1 before jumping to the cleanup > code when a local procedure call fails and the rc is overwritten, > however, some codes don't observe the rule and so invalid cleanups > are likely to happen.

Re: [libvirt] [PATCH] LXC fix rc handling in lxcVmStart

2009-10-13 Thread Chris Lalancette
Ryota Ozaki wrote: > Hi, > > In lxcVmStart we have to set rc = -1 before jumping to the cleanup > code when a local procedure call fails and the rc is overwritten, > however, some codes don't observe the rule and so invalid cleanups > are likely to happen. > > A simple solution for the defect is

[libvirt] [PATCH] LXC fix rc handling in lxcVmStart

2009-10-12 Thread Ryota Ozaki
Hi, In lxcVmStart we have to set rc = -1 before jumping to the cleanup code when a local procedure call fails and the rc is overwritten, however, some codes don't observe the rule and so invalid cleanups are likely to happen. A simple solution for the defect is to add rc = -1 before every jumping