Re: [libvirt] [PATCH] Log an error when we fail to set the COW attribute

2014-07-17 Thread Ján Tomko
On 07/17/2014 01:54 PM, John Ferlan wrote: > > > On 07/17/2014 06:22 AM, Ján Tomko wrote: >> Coverity complains about the return value of ioctl not being checked. >> >> Even though we carry on when this fails (just like qemu-img does), >> we can log an error. >> --- >> src/storage/storage_backen

Re: [libvirt] [PATCH] Log an error when we fail to set the COW attribute

2014-07-17 Thread John Ferlan
On 07/17/2014 06:22 AM, Ján Tomko wrote: > Coverity complains about the return value of ioctl not being checked. > > Even though we carry on when this fails (just like qemu-img does), > we can log an error. > --- > src/storage/storage_backend.c | 9 +++-- > 1 file changed, 7 insertions(+),

[libvirt] [PATCH] Log an error when we fail to set the COW attribute

2014-07-17 Thread Ján Tomko
Coverity complains about the return value of ioctl not being checked. Even though we carry on when this fails (just like qemu-img does), we can log an error. --- src/storage/storage_backend.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend.