Re: [libvirt] [PATCH] Make error reporting in libvirtd thread safe

2011-04-13 Thread Daniel P. Berrange
On Wed, Mar 23, 2011 at 04:52:47PM +0100, Jiri Denemark wrote: > Bug https://bugzilla.redhat.com/show_bug.cgi?id=689374 reported libvirtd > crash during error dispatch. > > The reason is that libvirtd uses remoteDispatchConnError() with non-NULL > conn parameter which means that virConnGetLastErro

Re: [libvirt] [PATCH] Make error reporting in libvirtd thread safe

2011-03-24 Thread Jiri Denemark
On Wed, Mar 23, 2011 at 11:01:32 -0600, Eric Blake wrote: > > diff --git a/daemon/remote.c b/daemon/remote.c > > index a8fef4d..4b42ed2 100644 > > --- a/daemon/remote.c > > +++ b/daemon/remote.c > > @@ -757,8 +757,8 @@ remoteDispatchDomainGetSchedulerType (struct > > qemud_server *server ATTRIBUTE

Re: [libvirt] [PATCH] Make error reporting in libvirtd thread safe

2011-03-23 Thread Eric Blake
On 03/23/2011 09:52 AM, Jiri Denemark wrote: > Bug https://bugzilla.redhat.com/show_bug.cgi?id=689374 reported libvirtd > crash during error dispatch. > > The reason is that libvirtd uses remoteDispatchConnError() with non-NULL > conn parameter which means that virConnGetLastError() is used instea

[libvirt] [PATCH] Make error reporting in libvirtd thread safe

2011-03-23 Thread Jiri Denemark
Bug https://bugzilla.redhat.com/show_bug.cgi?id=689374 reported libvirtd crash during error dispatch. The reason is that libvirtd uses remoteDispatchConnError() with non-NULL conn parameter which means that virConnGetLastError() is used instead of its thread safe replacement virGetLastError(). So