Re: [libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-12 Thread Chris Lalancette
On 03/12/2010 10:10 AM, Luiz Capitulino wrote: > > Hi Chris, > > On Thu, 11 Mar 2010 18:00:56 -0500 > Chris Lalancette wrote: > >> The nodeGetInfo code was always assuming that machine had a >> single NUMA node, which is not correct. The good news is that >> libnuma gives us this information

Re: [libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-12 Thread Luiz Capitulino
Hi Chris, On Thu, 11 Mar 2010 18:00:56 -0500 Chris Lalancette wrote: > The nodeGetInfo code was always assuming that machine had a > single NUMA node, which is not correct. The good news is that > libnuma gives us this information pretty easily, so let's > properly report it. > > NOTE: With

Re: [libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-12 Thread Daniel Veillard
On Fri, Mar 12, 2010 at 08:45:23AM -0500, Chris Lalancette wrote: > On 03/12/2010 06:32 AM, Daniel Veillard wrote: > > On Thu, Mar 11, 2010 at 06:00:56PM -0500, Chris Lalancette wrote: > >> The nodeGetInfo code was always assuming that machine had a > >> single NUMA node, which is not correct. The

Re: [libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-12 Thread Chris Lalancette
On 03/12/2010 06:32 AM, Daniel Veillard wrote: > On Thu, Mar 11, 2010 at 06:00:56PM -0500, Chris Lalancette wrote: >> The nodeGetInfo code was always assuming that machine had a >> single NUMA node, which is not correct. The good news is that >> libnuma gives us this information pretty easily, so

Re: [libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-12 Thread Daniel Veillard
On Thu, Mar 11, 2010 at 06:00:56PM -0500, Chris Lalancette wrote: > The nodeGetInfo code was always assuming that machine had a > single NUMA node, which is not correct. The good news is that > libnuma gives us this information pretty easily, so let's > properly report it. okay > NOTE: With re

[libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-11 Thread Chris Lalancette
The nodeGetInfo code was always assuming that machine had a single NUMA node, which is not correct. The good news is that libnuma gives us this information pretty easily, so let's properly report it. NOTE: With recent hardware starting to support CPU hot-add and hot-remove, both this code and the