Re: [libvirt] [PATCH] Memory Leak Fix: Check def->info->alias before assigning

2013-11-27 Thread Daniel P. Berrange
On Wed, Nov 27, 2013 at 09:04:17PM +0530, Nehal J Wani wrote: > > The 'alias' attribute should *not* be parsed from the XML provided by > > the user. It should only be parsed in the live state XML. In the latter > > case no codepath should take us to qemuAssignDeviceAliases. So this is > > certainl

Re: [libvirt] [PATCH] Memory Leak Fix: Check def->info->alias before assigning

2013-11-27 Thread Eric Blake
On 11/27/2013 08:34 AM, Nehal J Wani wrote: >> The 'alias' attribute should *not* be parsed from the XML provided by >> the user. It should only be parsed in the live state XML. In the latter >> case no codepath should take us to qemuAssignDeviceAliases. So this is >> certainly not the right fix. I

Re: [libvirt] [PATCH] Memory Leak Fix: Check def->info->alias before assigning

2013-11-27 Thread Nehal J Wani
> The 'alias' attribute should *not* be parsed from the XML provided by > the user. It should only be parsed in the live state XML. In the latter > case no codepath should take us to qemuAssignDeviceAliases. So this is > certainly not the right fix. It sounds like the test case is flawed to > me. S

Re: [libvirt] [PATCH] Memory Leak Fix: Check def->info->alias before assigning

2013-11-27 Thread Daniel P. Berrange
On Wed, Nov 27, 2013 at 03:08:18PM +0530, Nehal J Wani wrote: > > The 'alias' attribute should *not* be parsed from the XML provided by > > the user. It should only be parsed in the live state XML. In the latter > > case no codepath should take us to qemuAssignDeviceAliases. So this is > > certainl

Re: [libvirt] [PATCH] Memory Leak Fix: Check def->info->alias before assigning

2013-11-27 Thread Nehal J Wani
> The 'alias' attribute should *not* be parsed from the XML provided by > the user. It should only be parsed in the live state XML. In the latter > case no codepath should take us to qemuAssignDeviceAliases. So this is > certainly not the right fix. It sounds like the test case is flawed to > me. >

Re: [libvirt] [PATCH] Memory Leak Fix: Check def->info->alias before assigning

2013-11-27 Thread Daniel P. Berrange
On Wed, Nov 27, 2013 at 04:01:45AM +0530, Nehal J Wani wrote: > On running the command make -C tests valgrind, there used to be a bunch of > memory leaks shown by valgrind. Specifically, one can check it by running: > libtool --mode=execute valgrind --quiet --leak-check=full > --suppressions=./.va

Re: [libvirt] [PATCH] Memory Leak Fix: Check def->info->alias before assigning

2013-11-26 Thread Osier Yang
On 27/11/13 06:31, Nehal J Wani wrote: On running the command make -C tests valgrind, there used to be a bunch of memory leaks shown by valgrind. Specifically, one can check it by running: libtool --mode=execute valgrind --quiet --leak-check=full --suppressions=./.valgrind.supp qemuhotplugtest T

[libvirt] [PATCH] Memory Leak Fix: Check def->info->alias before assigning

2013-11-26 Thread Nehal J Wani
On running the command make -C tests valgrind, there used to be a bunch of memory leaks shown by valgrind. Specifically, one can check it by running: libtool --mode=execute valgrind --quiet --leak-check=full --suppressions=./.valgrind.supp qemuhotplugtest The issue was that def->info->alias was al